Add subtle web hover to interactive rows #5989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gaearon
force-pushed
the
subtle-web-hover
branch
from
7afaa48 to
2d92cae
Compare
haileyok
approved these changes
Oct 29, 2024
arcalinea
temporarily deployed
to
subtle-web-hover - social-app PR #5989
Render
Destroyed
estrattonbailey
added a commit
that referenced
this pull request
Oct 31, 2024
* origin/main: (213 commits) add Thai Language translation support (#5879) fix warning on labeler profile: emoji detected but emoji not enabled (#6011) Added blur to search's onPressMenu (#6017) React compiler beta and reenable rule (#5898) Sort imports (#6009) Clarify build instructions (#6008) Upgrade all tiptap deps to latest (#5232) width full on text container (#6007) Bump 1.94.0 (#6006) Add subtle web hover to interactive rows (#5989) Settings revamp (#5745) Show almost-instant preview when opening lightbox (#6000) Refactor lightbox model to plain object (#5999) temp revert to old modal (#6005) Extend composer checks to all posts in a thread (#5955) Remove indirection when rendering composer state (#5954) Refactor composer state for threads (#5945) Disable Post button when empty (#5953) fix splash screen (#5997) Fix video quality for short videos (#5996) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posts and notifications are interactive but we're currently not providing a clue.
This adds a very slight hover to the interactive tap target, similar as on Twitter. Our existing contrast options are too hard so I used a half opacity. Didn't want to add another color value.
Review with no whitespace
hover_lite.mov
dim.mov
dark.mov
Test Plan
Web-only.
Verify posts in feed, posts in threads, posts in search, and different types of notifications.
Verify quotes get nested hover. Highlighted thread post should not get hover.
Note that I did not do this in threaded mode. The markup there is a bit too complex for my brain and I couldn't get the right area to highlight. I think it's fine, we can follow-up if desirable.