Fix font display on Android #5776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
haileyok
reviewed
Oct 17, 2024
src/alf/fonts.ts
Outdated
Comment on lines
106
to
122
| export function DO_NOT_USE() { | ||
| return useFonts({ | ||
| InterVariable: require('../../assets/fonts/inter/InterVariable.ttf'), | ||
| 'InterVariable-Italic': require('../../assets/fonts/inter/InterVariable-Italic.ttf'), | ||
| }) | ||
| return useFonts( | ||
| isAndroid | ||
| ? { | ||
| 'Inter-Regular': require('../../assets/fonts/inter/Inter-Regular.otf'), | ||
| 'Inter-Italic': require('../../assets/fonts/inter/Inter-Italic.otf'), | ||
| 'Inter-Bold': require('../../assets/fonts/inter/Inter-SemiBold.otf'), | ||
| 'Inter-BoldItalic': require('../../assets/fonts/inter/Inter-SemiBoldItalic.otf'), | ||
| 'Inter-Black': require('../../assets/fonts/inter/Inter-ExtraBold.otf'), | ||
| 'Inter-BlackItalic': require('../../assets/fonts/inter/Inter-ExtraBoldItalic.otf'), | ||
| } | ||
| : { | ||
| InterVariable: require('../../assets/fonts/inter/InterVariable.ttf'), | ||
| 'InterVariable-Italic': require('../../assets/fonts/inter/InterVariable-Italic.ttf'), | ||
| }, | ||
| ) | ||
| } |
There was a problem hiding this comment.
Can we platform split this? Pretty sure this will bloat our bundle sizes on web.
There was a problem hiding this comment.
Fixed. Yeah the bot here was reporting totally assets, but those fonts wouldn't have actually loaded. Much better now though, thanks for the bump 👍
haileyok
approved these changes
Oct 17, 2024
estrattonbailey
force-pushed
the
android-fonts
branch
from
60bccd2 to
e72171d
Compare
arcalinea
temporarily deployed
to
android-fonts - social-app PR #5776
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a thorough investigation and a few hints here and there like this one, it would appear that RN for Android doesn't support
fontWeightorfontStylefor custom fonts, and so in turn does not support variable fonts.So the solve for this is to load separate font files for Android-only, and map weights and styles to the separate font files.
Android still appears to be using alternate glyphs for some characters, such as lowercase
a(it's usinga.1), but I haven't been able to determine how to turn those off on Android, and iOS and web still work correctly. So maybe that's an investigation for another time, since this seems to work fine otherwise and Inter technically supports these character alternates i.e. this shouldn't break anything afaik.