Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clipping issue with 2 image grid #5744

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Oct 14, 2024

Simply removes the aspect ratio of the container, since it didn't account for the gap

Before After
Screenshot 2024-10-14 at 13 29 19 Screenshot 2024-10-14 at 13 29 32

Copy link

github-actions bot commented Oct 14, 2024

Old size New size Diff
7.91 MB 7.91 MB 0 B (0.00%)

aspectRatio = undefined
break
}
let aspectRatio = count === 3 ? 2 : undefined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const?

@arcalinea arcalinea temporarily deployed to samuel/2-image-aspect-ratio - social-app PR #5744 October 28, 2024 15:52 — with Render Destroyed
@mozzius mozzius merged commit e652b2d into main Oct 28, 2024
6 checks passed
@mozzius mozzius deleted the samuel/2-image-aspect-ratio branch October 28, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants