Fix sheets to work nicely on ios 15 #5685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
hailey/ios-15-tweaks-sheet - social-app PR #5685
Render
Destroyed
|
The Pull Request introduced fingerprint changes against the base commit: Fingerprint diff[{"type":"dir","filePath":"modules/bottom-sheet/ios","reasons":["expoAutolinkingIos"],"hash":"a630f462f5c93a5d5f670dc95d79508d603fdb1e"}]Generated by PR labeler 🤖 |
|
arcalinea
temporarily deployed
to
hailey/ios-15-tweaks-sheet - social-app PR #5685
Render
Destroyed
haileyok
commented
Oct 11, 2024
Comment on lines
+73
to
+84
| let extraStyles | ||
| if (isIOS15 && this.state.viewHeight) { | ||
| const {viewHeight} = this.state | ||
| if (viewHeight < screenHeight / 2) { | ||
| extraStyles = { | ||
| height: viewHeight, | ||
| marginTop: screenHeight / 2 - viewHeight, | ||
| borderTopLeftRadius: cornerRadius, | ||
| borderTopRightRadius: cornerRadius, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Because we cannot actually use a custom detent on the native side on iOS 15, we can do some JS style hacks to make it appear the same.
haileyok
changed the title
preventExpansion on iOS 15
|
cc @surfdude29 thanks for the info!! |
arcalinea
temporarily deployed
to
hailey/ios-15-tweaks-sheet - social-app PR #5685
Render
Destroyed
estrattonbailey
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RocketSim_Recording_iPhone_SE_.3rd_generation._4.7_2024-10-10_17.52.41.mp4