Link cards #5677
Merged
Link cards #5677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
link-cards - social-app PR #5677
Render
Destroyed
|
arcalinea
temporarily deployed
to
link-cards - social-app PR #5677
Render
Destroyed
|
Also adjusted the remove button, didn't want to retake all screenshots |
arcalinea
temporarily deployed
to
link-cards - social-app PR #5677
Render
Destroyed
|
Updated fallback for failed link previews |
arcalinea
temporarily deployed
to
link-cards - social-app PR #5677
Render
Destroyed
gpp-0
pushed a commit
to gpp-0/bsky-app-fork
that referenced
this pull request
Oct 14, 2024
* New link card styles * Cleanup of consituent parts, add hover state * Fix gif alt text view * Fix alt text view more * Remove dupe * Update remove button * Remove added margin on gif
futurGH
reviewed
Oct 15, 2024
| style={[ | ||
| a.flex_row, | ||
| a.align_center, | ||
| a.gap_2xs, |
There was a problem hiding this comment.
please sir may I have some gap
|
It seems that the ability to remove videos on the web composer has broke with this change. I can't hover over the remove button
|
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
* New link card styles * Cleanup of consituent parts, add hover state * Fix gif alt text view * Fix alt text view more * Remove dupe * Update remove button * Remove added margin on gif
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
* New link card styles * Cleanup of consituent parts, add hover state * Fix gif alt text view * Fix alt text view more * Remove dupe * Update remove button * Remove added margin on gif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught a brain worm last night, felt these link cards and such were kinda wacky and not "clean". Played around and ended up here. This also adds a hover state on web, which is pretty nice.
