Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the email verification dialog #5663

Merged
merged 19 commits into from
Oct 10, 2024
Merged

Update the email verification dialog #5663

merged 19 commits into from
Oct 10, 2024

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented Oct 9, 2024 •
edited
Loading

Test Plan

Web Desktop

Screenshot 2024-10-10 at 12 11 08 PM

Screenshot 2024-10-09 at 1 58 49 PM

Web Mobile

Screenshot 2024-10-10 at 12 11 16 PM

Screenshot 2024-10-09 at 1 59 17 PM

Native

RocketSim_Screenshot_iPhone_16_Pro_6 3_2024-10-10_12 07 49

Screenshot 2024-10-09 at 1 59 30 PM

@arcalinea arcalinea temporarily deployed to hailey/verify-email-dialog-alf - social-app PR #5663 October 9, 2024 21:00 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to hailey/verify-email-dialog-alf - social-app PR #5663 October 9, 2024 21:06 — with Render Destroyed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024 •
edited
Loading

Old size New size Diff
7.89 MB 7.89 MB 96 B (0.00%)

@arcalinea arcalinea temporarily deployed to hailey/verify-email-dialog-alf - social-app PR #5663 October 10, 2024 19:13 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to hailey/verify-email-dialog-alf - social-app PR #5663 October 10, 2024 19:29 — with Render Destroyed
@haileyok haileyok changed the title alf email confirmation dialog Update the email verification dialog Oct 10, 2024
@haileyok haileyok marked this pull request as ready for review October 10, 2024 19:29
@arcalinea arcalinea temporarily deployed to hailey/verify-email-dialog-alf - social-app PR #5663 October 10, 2024 19:30 — with Render Destroyed
estrattonbailey
estrattonbailey approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works great, just a few design nitpicks

@arcalinea arcalinea temporarily deployed to hailey/verify-email-dialog-alf - social-app PR #5663 October 10, 2024 21:20 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to hailey/verify-email-dialog-alf - social-app PR #5663 October 10, 2024 21:26 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to hailey/verify-email-dialog-alf - social-app PR #5663 October 10, 2024 21:36 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to hailey/verify-email-dialog-alf - social-app PR #5663 October 10, 2024 21:41 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to hailey/verify-email-dialog-alf - social-app PR #5663 October 10, 2024 21:58 — with Render Destroyed
@haileyok haileyok merged commit 2ebe8f4 into main Oct 10, 2024
6 checks passed
@haileyok haileyok deleted the hailey/verify-email-dialog-alf branch October 10, 2024 22:02
haileyok added a commit that referenced this pull request Oct 12, 2024
@haileyok
Revert "Update the email verification dialog (#5663)"
6550029 
This reverts commit 2ebe8f4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surfdude29 surfdude29 surfdude29 left review comments

@estrattonbailey estrattonbailey estrattonbailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haileyok @estrattonbailey @surfdude29 @arcalinea