Improve codegen bundle size and typings #2999
Conversation
matthieusieben
force-pushed
the
msi/lex-gen-optimization
branch
2 times, most recently
from
9ed3816
to
5400766
Compare
matthieusieben
force-pushed
the
msi/lex-gen-optimization
branch
from
2abd90e
to
ef8af3f
Compare
matthieusieben
changed the title
matthieusieben
force-pushed
the
msi/lex-gen-optimization
branch
2 times, most recently
from
bebca0e
to
0bea135
Compare
matthieusieben
force-pushed
the
msi/lex-gen-optimization
branch
from
0bea135
to
02ddb9a
Compare
matthieusieben
force-pushed
the
msi/lex-gen-optimization
branch
from
02ddb9a
to
1a337a2
Compare
| cd packages/pds; pnpm run codegen | ||
| cd packages/bsky; pnpm run codegen | ||
| cd packages/ozone; pnpm run codegen | ||
| pnpm run --parallel codegen |
There was a problem hiding this comment.
For consistency, we could do this more similarly to how we do the build task. That is, do a pnpm codegen here on the makefile, and "codegen": "pnpm run --parallel codegen", in package.json.
| @@ -1,24 +1,18 @@ | |||
| const TID_LENGTH = 13 | |||
| const TID_REGEX = /^[234567abcdefghij][234567abcdefghijklmnopqrstuvwxyz]{12}$/ | |||
|
|
|||
| export const ensureValidTid = (tid: string): void => { | |||
| if (tid.length !== 13) { | |||
There was a problem hiding this comment.
Forgot to use the constant here.
| export function isObj(obj: unknown): obj is Record<string, unknown> { | ||
| return obj !== null && typeof obj === 'object' | ||
| export function isObj<V>(v: V): v is V & object { | ||
| return v != null && typeof v === 'object' |
There was a problem hiding this comment.
I found it a bit weird that we would want to use != instead of !==. In this case, it doesn't seem to make a difference. Just mentioning in case you did it by accident. Could probably be !!v as well, so it is less ambiguous.
BTW, are we fine with isObj returning true for arrays? I'm just wondering if that's the behavior we expect in this project from isObj, despite arrays being objects at the language level.
This PR is the first of a 3 step changes aimed at improving typing in the atproto repo:
$typeproperty to records and user object typesNote
When reviewing, "codegen" commits can be ignored as they only contain generated code changes.