Remove ifdef guards around unit and HIL tests. #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydenroche5
force-pushed
the
simplify_macro_gates
branch
from
2cf39c9 to
b994518
Compare
zfields
approved these changes
Dec 22, 2023
These guards were our way of getting around the contents of these files being included in note-arduino builds. With this commit, we're getting rid of them. Instead, in note-arduino when we include note-c, we'll remove the test subdirectory all together. Then these files aren't even there to begin with, so they can't mess up the note-arduino build.
haydenroche5
force-pushed
the
simplify_macro_gates
branch
from
b994518 to
697eb2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These guards were our way of getting around the contents of these files being included in note-arduino builds. With this commit, we're getting rid of them. Instead, in note-arduino when we include note-c, we'll remove the test subdirectory all together. Then these files aren't even there to begin with, so they can't mess up the note-arduino build.