Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize private function naming. #117

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

haydenroche5
Copy link
Collaborator

@haydenroche5 haydenroche5 commented Oct 24, 2023

All internal/private functions in note-c should begin with a lowercase letter.

See #99 (comment).

All internal/private functions in note-c should begin with a lowercase letter.
@haydenroche5 haydenroche5 requested a review from zfields October 24, 2023 16:13
@haydenroche5 haydenroche5 self-assigned this Oct 24, 2023
@@ -82,7 +82,7 @@ static const char *daynames[] = {"Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"
// Forwards
NOTE_C_STATIC void setTime(JTIME seconds);
NOTE_C_STATIC bool timerExpiredSecs(uint32_t *timer, uint32_t periodSecs);
NOTE_C_STATIC int ytodays(int year);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whyTodays()? 😂

@haydenroche5 haydenroche5 merged commit 2b31718 into blues:master Oct 27, 2023
6 checks passed
@haydenroche5 haydenroche5 deleted the standardize_casing branch October 27, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants