Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #68

Merged
merged 7 commits into from
Sep 3, 2019
Merged

Update #68

merged 7 commits into from
Sep 3, 2019

Conversation

jaxxzer
Copy link
Member

@jaxxzer jaxxzer commented Aug 29, 2019

No description provided.

@jaxxzer jaxxzer requested a review from Williangalvani August 29, 2019 19:45
@jaxxzer jaxxzer force-pushed the update branch 3 times, most recently from 19fb1b0 to ba4c0e8 Compare August 30, 2019 20:39
@jaxxzer
Copy link
Member Author

jaxxzer commented Aug 30, 2019

@Williangalvani tools fixed moved version elevation to separate pr

@jaxxzer jaxxzer mentioned this pull request Aug 30, 2019
Merged
Copy link
Member

@Williangalvani Williangalvani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is looking good! I got everything working here with the companion PR, but I also found new issue:
python device.py --device [ping1d device] is failing not very graciously with ping1d 3.24:

pi@raspberrypi:~/ping-python/brping $ python device.py --device /dev/ttyUSB0
Opening /dev/ttyUSB0 at 115200 bps
Initialized: True

testing get_device_information
error unpacking payload: unpack requires a string argument of length 6
msg_data: BR�, header: (66, 82, 4, 4, 0, 0)
format: <BBBBBB, buf: 
BBBBBB
Traceback (most recent call last):
  File "device.py", line 212, in <module>
    result = p.get_device_information()
  File "device.py", line 165, in get_device_information
    if self.request(definitions.COMMON_DEVICE_INFORMATION) is None:
  File "device.py", line 98, in request
    return self.wait_message([m_id], timeout)
  File "device.py", line 110, in wait_message
    msg = self.read()
  File "device.py", line 57, in read
    self.handle_message(self.parser.rx_msg)
  File "device.py", line 129, in handle_message
    setattr(self, "_" + attr, getattr(msg, attr))
AttributeError: 'PingMessage' object has no attribute 'device_type'

I just try/excepted the message request and it works fine for the enumerator, but this error is not user-friendly at all and will confuse users just as it is confusing me.

brping/pingmessage.py Outdated Show resolved Hide resolved
@jaxxzer
Copy link
Member Author

jaxxzer commented Sep 3, 2019

ping1d 3.24:

thanks @Williangalvani , I'll point out that this is not working with any current release of ping1d. We broke the 'device information message' in ping-protocol 1.0.0.

I can do a better fail here.

@jaxxzer jaxxzer merged commit f50b954 into bluerobotics:master Sep 3, 2019
@jaxxzer jaxxzer deleted the update branch September 3, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants