Add device classes #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
requested changes
Aug 27, 2019
jaxxzer
force-pushed
the
device
branch
2 times, most recently
from
ab3cf9b to
4a66376
Compare
Williangalvani
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #66
This pr adds a
PingDevicebase class, andPing1DandPing360sub-classes. This is analagous to ourPingSensorclass inping-viewer.We have already the message-api for ping360. This adds a device-api with easy calls like
setAngle()andsetGain().There are test cases for each device class when the module is run as main.