Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the deletion of data-lake variables when an input widget is removed #1715

Conversation

ArturoManzoli
Copy link
Contributor

Fixes #1711

Copy link
Contributor

@ES-Alexander ES-Alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working as expected - nice! :-)

It's probably worth adding deletion capabilities to the data lake variable monitor (so there's at least some way of deleting variables), but that seems potentially out of scope for this PR. @rafaellehmkuhl thoughts on this? It seems somewhat relevant to the changes I suggested over here.

I suppose longer term it would be nice if we could detect whether a variable is being used anywhere else, and delete it automatically when the last reference to it is removed (like garbage collection in a programming language), but I don't expect we have such tight knowledge over everywhere each variable is used at the moment, or a reference count 🤷‍♂️

@rafaellehmkuhl
Copy link
Member

Seems to be working as expected - nice! :-)

It's probably worth adding deletion capabilities to the data lake variable monitor (so there's at least some way of deleting variables), but that seems potentially out of scope for this PR. @rafaellehmkuhl thoughts on this? It seems somewhat relevant to the changes I suggested over here.

I suppose longer term it would be nice if we could detect whether a variable is being used anywhere else, and delete it automatically when the last reference to it is removed (like garbage collection in a programming language), but I don't expect we have such tight knowledge over everywhere each variable is used at the moment, or a reference count 🤷‍♂️

It's something we want to have, yes, but it needs the link to source and garbage collection, as you said.
I'm working on something similar for #1642.

Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not showing the selected variable for an existing input widget.

image

@rafaellehmkuhl rafaellehmkuhl self-requested a review February 25, 2025 11:33
@rafaellehmkuhl
Copy link
Member

rafaellehmkuhl commented Feb 25, 2025

It's not showing the selected variable for an existing input widget.

Nevermind. Cleaning the cache solved the problem.

@ArturoManzoli ArturoManzoli merged commit 17bd032 into bluerobotics:master Feb 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting an input widget deletes the associated data lake variable
3 participants