Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript-actions: Try to execute all available actions on startup #1707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rafaellehmkuhl
Copy link
Member

No description provided.

@ArturoManzoli
Copy link
Contributor

Is it safe to execute all actions on startup?

If some of them are bound to a dangerous or any other sensitive action?

@rafaellehmkuhl
Copy link
Member Author

Is it safe to execute all actions on startup?

If some of them are bound to a dangerous or any other sensitive action?

Maybe, or maybe not.

As @ES-Alexander said yesterday, it should be opt-in to the user. Will change that.

@ES-Alexander
Copy link
Contributor

I understand this is valuable for some applications, but this definitely needs to be opt-in, per Action - someone may program an Action that runs some physical hardware, or even damages part of their vehicle as an emergency stop or something, and we don't want to be arbitrarily running things like that automatically.

Also, is there a reason to restrict this to only JS Actions, instead of allowing it to apply to all of them?

Both things seem solvable with a "run on startup" checkbox column in the Actions manager. It would be nice to include the built in actions there, just without edit buttons (and possibly greyed out to make it obvious they're not changeable).

P.S. sorry - I just found this half-written - realised I didn't finish and submit it this morning as intended 😅

@rafaellehmkuhl
Copy link
Member Author

I understand this is valuable for some applications, but this definitely needs to be opt-in, per Action - someone may program an Action that runs some physical hardware, or even damages part of their vehicle as an emergency stop or something, and we don't want to be arbitrarily running things like that automatically.

Also, is there a reason to restrict this to only JS Actions, instead of allowing it to apply to all of them?

Both things seem solvable with a "run on startup" checkbox column in the Actions manager. It would be nice to include the built in actions there, just without edit buttons (and possibly greyed out to make it obvious they're not changeable).

P.S. sorry - I just found this half-written - realised I didn't finish and submit it this morning as intended 😅

Agree with all. Will do the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants