Add system settings manager #1685

ArturoManzoli · 2025-02-11T14:33:34Z

Users can edit, save and upload settings;
Reset settings button will be implemented on a second approach. For now a reset for the browser storage is implemented only.

Screenshare.-.2025-02-14.9_18_13.AM.mp4

rafaellehmkuhl · 2025-02-11T15:15:08Z

src/assets/defaults.ts

@@ -901,3 +907,90 @@ export const defaultSensorDataloggerProfile: OverlayGrid = {
 export const defaultDisplayUnitPreferences = {
  distance: DistanceDisplayUnit.Meters,
 }
+
+export const defaultCockpitSettings = {


I liked the idea of having all the defaults centralized in one place!

One thing thought is that we need to use those in the places where they are required (e.g.: calls to useStorage and useBlueOsStorage), otherwise if someone changes the value there, the value here will be deprecated and the code will not work.

rafaellehmkuhl · 2025-02-11T15:17:20Z

src/assets/defaults.ts

+    { level: 'warning', enabled: true },
+    { level: 'critical', enabled: true },
+  ],
+  'cockpit-mission-start-time': '2025-02-10T21:34:50.113Z',


It's crucial that we don't change the default values from what they are today. This one should be new Date(), and not that random date.

The same happens for several others. I believe you copied your own settings instead of the real defaults.

rafaellehmkuhl · 2025-02-12T18:27:16Z

src/components/configuration/ManageCockpitSettings.vue

+
+// Trying to sync automatically
+watch(
+  () => userSettings.value,


A tip here: it looks like you're creating an extra localStorage entry to store a duplication of all variables just to be alerted by the useStorage composable about changes in the value. You can instead just listen to the "storage" event. This way you don't duplicate everything (which can cause a lot of confusion for someone reading the stored values, as there would be two possible two sources of truth) and you can monitor for changes directly in the values of the keys.

addEventListener("storage", (event) => {});

Actually, from this code, I assume you're not receiving changes made to the original settings, right?

Correct, I'm not receiving the changes.

Actually what I was trying to do there was to check for changes on the local copy of the settings. and if there was any change, save it to the storage.

I'll implement the event listener and check the results

rafaellehmkuhl · 2025-02-14T13:19:19Z

src/views/ConfigurationGeneralView.vue

@@ -519,7 +533,6 @@ const tryToPrettifyRtcConfig = (): void => {

 const openTutorial = (): void => {
  interfaceStore.isMainMenuVisible = false
-  interfaceStore.configComponent = -1


To better understand, why was this removed?

Maybe this should be on its own commit.

On a recent PR you added a 'tools' submenu that modified a little bit the way submenus and its contents work. This was leftover from that, I suppose.

Got it! Was a leftover indeed!

Yes, makes sense to be on a separate PR.

Sad that our linter is partially broken and not catching all errors. I should revisit the PR that fixes it at some point.

Sorry, I meant commit and not PR 😅

rafaellehmkuhl · 2025-02-14T16:58:32Z

src/views/ConfigurationGeneralView.vue

                  Show tutorial
                </v-btn>
                <v-btn
-                  v-if="isElectron()"


This if should not be removed. It guarantees we don't show the button to open the folder while in a browser, which doesn't work.

That was a mistake I made. Nice that you saw. I was checking the menu with all buttons and forgot to put this back.

Returning now. Thanks

rafaellehmkuhl · 2025-02-14T17:01:11Z

src/components/configuration/CockpitSettingsManager.vue

+        text: 'Reset settings',
+        action: () => {
+          localStorage.clear()
+          location.reload()


This will reload the page immediately, so the snackbar won't show or will do for a quick moment.

There's a utils method that deals with warning about the reload and setting a timeout so the user can read any message left. It can help here.

rafaellehmkuhl

Code looks good now.
Will just test it before approve.

rafaellehmkuhl

Could we have an edit button in the right to enable editing the value? Or maybe enabling it with a single click? Having to double-click requires the user to guess what to do. It's also not working on touch/mobile.

ArturoManzoli · 2025-02-18T14:02:31Z

Could we have an edit button in the right to enable editing the value? Or maybe enabling it with a single click? Having to double-click requires the user to guess what to do. It's also not working on touch/mobile.

Done!

rafaellehmkuhl

I got somewhat confused with the behavior of the edit button. When I click it, it says "Done" and puts a green checkmark. It seems like something was completed. Strange and unexpected for an edit button. Is the checkmark like a "save" button?

Kapture.2025-02-19.at.09.39.22.mp4

It's also unexpected to have different behaviors in those terms between the JSON variables and the primitive ones. Could we instead have the same for both?

A suggestion would be:

Instead of the "Edit json" button, put a "{ ... }" there, as this was supposed to be the value, and we are not showing just because it doesn't fit there
Use a pencil icon to start editing in all cases (json and not-json)
Have the "Close" and "Save" buttons as the way to undo and save for all cases (json or primitive)
Add a visual hint for the string and number values, as currently they don't seem to have entered an edit mode (different from the boolean and json ones, where this is clear)

With those implemented I think it would be much clear how to use the tool, as the behavior would be consistent.

ArturoManzoli · 2025-02-19T12:53:06Z

I got somewhat confused with the behavior of the edit button. When I click it, it says "Done" and puts a green checkmark. It seems like something was completed. Strange and unexpected for an edit button. Is the checkmark like a "save" button?

Kapture.2025-02-19.at.09.39.22.mp4
It's also unexpected to have different behaviors in those terms between the JSON variables and the primitive ones. Could we instead have the same for both?

A suggestion would be:

Instead of the "Edit json" button, put a "{ ... }" there, as this was supposed to be the value, and we are not showing just because it doesn't fit there

Use a pencil icon to start editing in all cases (json and not-json)

Have the "Close" and "Save" buttons as the way to undo and save for all cases (json or primitive)

Add a visual hint for the string and number values, as currently they don't seem to have entered an edit mode (different from the boolean and json ones, where this is clear)

With those implemented I think it would be much clear how to use the tool, as the behavior would be consistent.

Nice, I agree with your suggestions.
The checkmark is indeed a save button, but the way its changing from pencil to checkmark may be misunderstood.
I'll try to unify and make the interaction consistent among primitives and objects

…component

Signed-off-by: Arturo Manzoli <[email protected]>

ArturoManzoli · 2025-02-19T17:59:37Z

On last patch:

Added 'save' and 'cancel' buttons for primitives editing;
Made more clear when a primitive value is being edited;
Positioned the tooltips over the top of their parents;
Fixed null variables not opening the input area (check last-mission-name and username values)

Screenshare.-.2025-02-19.2_52_51.PM.mp4

rafaellehmkuhl

For some reason it is showing this old "main-menu-style" variable (which was replaced by "cockpit-main-menu-style"), even with it not being in my localStorage anymore.

Also, if i change any other variable, this old "main-menu-style" variable is being recreated.

.

Could we also add a clear button in the search input?

ArturoManzoli force-pushed the 1486-Cockpit-is-missing-the-option-to-reset-settings branch from 2194b7d to 6617c9f Compare February 11, 2025 14:37

rafaellehmkuhl requested changes Feb 11, 2025

View reviewed changes

rafaellehmkuhl mentioned this pull request Feb 11, 2025

Handle automatically all settings sync conflicts (BlueOS vs Cockpit) #1684

Open

rafaellehmkuhl reviewed Feb 12, 2025

View reviewed changes

ArturoManzoli force-pushed the 1486-Cockpit-is-missing-the-option-to-reset-settings branch from 6617c9f to 8119e18 Compare February 14, 2025 12:25

ArturoManzoli requested a review from rafaellehmkuhl February 14, 2025 12:28

rafaellehmkuhl reviewed Feb 14, 2025

View reviewed changes

ArturoManzoli marked this pull request as ready for review February 14, 2025 15:59

ArturoManzoli requested a review from rafaellehmkuhl February 14, 2025 15:59

ArturoManzoli force-pushed the 1486-Cockpit-is-missing-the-option-to-reset-settings branch from 8119e18 to cb7c4d5 Compare February 14, 2025 16:34

rafaellehmkuhl requested changes Feb 14, 2025

View reviewed changes

ArturoManzoli force-pushed the 1486-Cockpit-is-missing-the-option-to-reset-settings branch from a8efdd6 to 9385ddd Compare February 14, 2025 17:20

ArturoManzoli requested a review from rafaellehmkuhl February 14, 2025 17:22

rafaellehmkuhl reviewed Feb 14, 2025

View reviewed changes

rafaellehmkuhl reviewed Feb 17, 2025

View reviewed changes

ArturoManzoli force-pushed the 1486-Cockpit-is-missing-the-option-to-reset-settings branch from 9385ddd to 6039ec3 Compare February 18, 2025 14:00

ArturoManzoli requested a review from rafaellehmkuhl February 18, 2025 14:02

rafaellehmkuhl requested changes Feb 19, 2025

View reviewed changes

ArturoManzoli added 2 commits February 19, 2025 14:55

Components: Cockpit-settings-manager: Implement first version of the …

bf07ebe

…component

App: Main-menu: Remove leftover from submenu logic change

254cba4

Signed-off-by: Arturo Manzoli <[email protected]>

ArturoManzoli force-pushed the 1486-Cockpit-is-missing-the-option-to-reset-settings branch from 6039ec3 to 254cba4 Compare February 19, 2025 17:55

ArturoManzoli requested a review from rafaellehmkuhl February 19, 2025 18:00

rafaellehmkuhl requested changes Feb 20, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add system settings manager #1685

Add system settings manager #1685

ArturoManzoli commented Feb 11, 2025 •

edited

Loading

rafaellehmkuhl Feb 11, 2025

rafaellehmkuhl Feb 11, 2025

rafaellehmkuhl Feb 12, 2025

ArturoManzoli Feb 13, 2025

rafaellehmkuhl Feb 14, 2025

ArturoManzoli Feb 14, 2025 •

edited

Loading

rafaellehmkuhl Feb 14, 2025

ArturoManzoli Feb 14, 2025 •

edited

Loading

rafaellehmkuhl Feb 14, 2025

rafaellehmkuhl Feb 14, 2025

ArturoManzoli Feb 14, 2025

rafaellehmkuhl Feb 14, 2025

rafaellehmkuhl left a comment

rafaellehmkuhl left a comment

ArturoManzoli commented Feb 18, 2025

rafaellehmkuhl left a comment •

edited

Loading

ArturoManzoli commented Feb 19, 2025

ArturoManzoli commented Feb 19, 2025

rafaellehmkuhl left a comment •

edited

Loading

Add system settings manager #1685

Are you sure you want to change the base?

Add system settings manager #1685

Conversation

ArturoManzoli commented Feb 11, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArturoManzoli Feb 14, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArturoManzoli Feb 14, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rafaellehmkuhl left a comment

Choose a reason for hiding this comment

rafaellehmkuhl left a comment

Choose a reason for hiding this comment

ArturoManzoli commented Feb 18, 2025

rafaellehmkuhl left a comment • edited Loading

Choose a reason for hiding this comment

ArturoManzoli commented Feb 19, 2025

ArturoManzoli commented Feb 19, 2025

rafaellehmkuhl left a comment • edited Loading

Choose a reason for hiding this comment

ArturoManzoli commented Feb 11, 2025 •

edited

Loading

ArturoManzoli Feb 14, 2025 •

edited

Loading

ArturoManzoli Feb 14, 2025 •

edited

Loading

rafaellehmkuhl left a comment •

edited

Loading

rafaellehmkuhl left a comment •

edited

Loading