Allow data-lake variables to auto trigger actions

[rafaellehmkuhl]

.

To be merged after #1674
Fix #1641

[ArturoManzoli]

Still reviewing code, but for now, there is an UI issue:

• Change the save button text color to white (1)

[ES-Alexander]

The actual triggering seems to work, but:

• There's no description of the link functionality in the help text at the top
  • e.g. "Actions can be run manually, or configured to trigger automatically when a linked Data Lake variable changes"
• Dropdown is light themed (and so are the others in the Actions section), while the rest of the interface uses dark ones:
  
• Variables aren't searchable, so you need to scroll for ages to find what you're looking for
• Configured variables can't be removed from in the bar, so they need to be found again
  • Each selected pill should ideally have a little x on the right for removing it

As something of a side note, it's hard to test using actual values, because they can't be set manually, and #1542 means sliders seemingly can't be used for integer values, and #1678 means dials aren't usable for PWM values and the like :(

[rafaellehmkuhl]

The actual triggering seems to work, but:
Will fix all the raised points.

As something of a side note, it's hard to test using actual values, because they can't be set manually, and #1542 means sliders seemingly can't be used for integer values, and #1678 means dials aren't usable for PWM values and the like :(

Yeah...
I need to add that functionality for adding/removing variables and persist them, but while that, try this branch, as it adds the hardcoded variables for the camera.

[ArturoManzoli]

It works very well.
But is it possible to set a value or a range for that data lake variable to trigger the action? If not, could it be implemented on this PR?

For example, if water temp goes above 28º C, trigger the action that let some cold water in.

[rafaellehmkuhl]

It works very well. But is it possible to set a value or a range for that data lake variable to trigger the action? If not, could it be implemented on this PR?

For example, if water temp goes above 28º C, trigger the action that let some cold water in.

I think it can fit here, yes. Let me give it a try!

[rafaellehmkuhl]

It works very well. But is it possible to set a value or a range for that data lake variable to trigger the action? If not, could it be implemented on this PR?
For example, if water temp goes above 28º C, trigger the action that let some cold water in.

I think it can fit here, yes. Let me give it a try!

@ArturoManzoli, about that, I was reviewing the auto-trigger functionality and its architecture, and I'm yet unsure if this threshold behavior would be best fitted here and how, since we can have different types of variables (booleans, numbers and strings), and a dedicated interface would be needed for each one.

I propose we go with the base functionality as it is, as it fulfills the needs for the radcam support, and leave the extended functionality (trigger on condition) for a future PR. I can open an issue to track that as well.

@ES-Alexander do you remember if there's an issue around that already?

[rafaellehmkuhl]

The actual triggering seems to work, but:

• There's no description of the link functionality in the help text at the top

  • e.g. "Actions can be run manually, or configured to trigger automatically when a linked Data Lake variable changes"

• Dropdown is light themed (and so are the others in the Actions section), while the rest of the interface uses dark ones:

• Variables aren't searchable, so you need to scroll for ages to find what you're looking for

• Configured variables can't be removed from in the bar, so they need to be found again

  • Each selected pill should ideally have a little x on the right for removing it

As something of a side note, it's hard to test using actual values, because they can't be set manually, and #1542 means sliders seemingly can't be used for integer values, and #1678 means dials aren't usable for PWM values and the like :(

All done!

[ArturoManzoli]

I propose we go with the base functionality as it is, as it fulfills the needs for the radcam support, and leave the extended functionality (trigger on condition) for a future PR. I can open an issue to track that as well.

Sure, no problem

[ArturoManzoli]

Works very well!

Those CSS problems @ES-Alexander mentioned were only visible on macOS's Crome.
I've seen that before and it usually happens on selectors and color pickers from vuetify.
Let's keep an eye on them.

[ES-Alexander]

I propose we go with the base functionality as it is, as it fulfills the needs for the radcam support, and leave the extended functionality (trigger on condition) for a future PR. I can open an issue to track that as well.

@ES-Alexander do you remember if there's an issue around that already?

@rafaellehmkuhl it's covered by idea 3 in #1538, but is perhaps still worth having a dedicated sub-issue for? :-)

[ES-Alexander]

Mostly working well and looking good now! :D

A minor polish problem is that searching opens the dropdown without the dropdown element realising it is open, so then clicking out of the search bar keeps it open, and you need to click twice on the dropdown component arrow to make it close properly:

Screen.Recording.2025-02-19.at.4.33.39.am.mov

There also seems to be an internal blue element highlight for the dropdown components, which seems unnecessary and looks weird.

[ES-Alexander]

Suggested change

	<li>
	You can also link actions to Data Lake variables, by clicking the link icon. When configuring that, any
	changes to the variable value will automatically trigger the linked action.
	</li>
	<li>
	The link button can be used to link Actions to Data Lake variables, so that changes to the variable
	value will automatically trigger the linked action.
	</li>
	<li>Actions can also be tested/run manually, using the play button.</li>

[rafaellehmkuhl]

Mostly working well and looking good now! :D

A minor polish problem is that searching opens the dropdown without the dropdown element realising it is open, so then clicking out of the search bar keeps it open, and you need to click twice on the dropdown component arrow to make it close properly:

There also seems to be an internal blue element highlight for the dropdown components, which seems unnecessary and looks weird.

All fixed.
I made it so the dropdown menu opens automatically when the search is focused (so the user can readily see the results) and closed when it is unfocused or cleared.

[rafaellehmkuhl]

@ES-Alexander @Williangalvani let me know what you think.

Also another question: should the minimum interval between calls be only for auto-trigs or for any trigs (like joystick button calls)? I'm leaning for the latter, as it solves two problems with the same implementation and gets clearer to the user as well.

[ES-Alexander]

Looking good :-)
It seems redundant to have a separate button for the link/interval stuff if they're part of the global configuration though - maybe just add the configuration for that to the normal edit window? :-)

[rafaellehmkuhl]

Looking good :-) It seems redundant to have a separate button for the link/interval stuff if they're part of the global configuration though - maybe just add the configuration for that to the normal edit window? :-)

Yeah, agree. Let me take a look how that could be handled. The main problem today is that the custom actions have each their custom settings dialog, so we need to decide on how to separate the "general" settings for that action from the "specific" settings of that action type. Maybe tabs? I like tabs because they give you clean UIs, but I don't like that part of the settings are "hidden" in a separate tab.

[ES-Alexander]

Maybe tabs? I like tabs because they give you clean UIs, but I don't like that part of the settings are "hidden" in a separate tab.

Expandable sections are another option that are already in use throughout Cockpit.

I don't always love them, but it would allow having usage settings and definition configuration in the same window 🤷‍♂️