Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MDI icon over our own and update depth indicator style #1570

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Use MDI icon over our own and update depth indicator style #1570

merged 3 commits into from
Jan 15, 2025

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Jan 15, 2025 •
edited
Loading

old:
image

new:
image
image

@patrickelectric patrickelectric force-pushed the use-mdi-icon branch 3 times, most recently from f5a84aa to 368ba65 Compare January 15, 2025 12:42
rafaellehmkuhl
rafaellehmkuhl requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style changes seem to be working fine!

Could you squash commits 1+4 and 2+3 before merging?

@patrickelectric
Copy link
Member Author

@rafaellehmkuhl done

@rafaellehmkuhl rafaellehmkuhl merged commit e829a7e into bluerobotics:master Jan 15, 2025
11 checks passed
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Jan 16, 2025
@ES-Alexander ES-Alexander mentioned this pull request Jan 20, 2025
Merged
@ES-Alexander ES-Alexander added the docs-in-progress Included in an open docs PR label Jan 20, 2025
@vshie
Copy link

vshie commented Jan 21, 2025

An equivalent graphic for altitude, with arrow pointing down and maybe a horizontal line would be handy for surftrack / general altimeter usage! (sorry if this exists and I'm not aware, searching icons always feels a bit like a keyword guessing game)

@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented docs-in-progress Included in an open docs PR labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaellehmkuhl rafaellehmkuhl rafaellehmkuhl approved these changes

@ArturoManzoli ArturoManzoli Awaiting requested review from ArturoManzoli

Assignees
No one assigned
Labels
docs-complete Change documentation has been completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrickelectric @vshie @rafaellehmkuhl @ES-Alexander