joystick-config: Fix warning about manual-control message not being supported #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upported It was mistakenly warning about the `MANUAL_CONTROL` message not being supported when it failed to fetch the information from BlueOS.
|
I have put this one in draft mode because besides the logic being now correct, the conditional rendering for the warning slot is wrong. Will fix that and reopen. |
… of info and warning slots As it was, once the component was rendered, the existence of info and warning slots would never change. We had a case where the joystick panel was initiated without a warning, but once an external API was consulted, the component tried to show the warning (with a change in a `v-if` for the slot), but the panel never rendered the warning, as it was not reactive.
|
@ArturoManzoli PR ready. The root cause of this was that the warning slot of the |
ArturoManzoli
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was mistakenly warning about the
MANUAL_CONTROLmessage not being supported when it failed to fetch the information from BlueOS.Fix #1067