Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general: Inject dynamic version to about page #1455

Conversation

rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Nov 20, 2024

Calculates version based on last git tag or current commit hash (fallback). Works on browser, dev mode and Electron.

Also fixes the problem of not being able to reopen the about page after closing it by clicking outside the dialog.


image


Fix #1315

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For support, it would be nice to have the build date, and the tag to be a hyperlink to the changelog in github as we do in BlueOS.

@rafaellehmkuhl
Copy link
Member Author

For support, it would be nice to have the build date, and the tag to be a hyperlink to the changelog in github as we do in BlueOS.

Will do!

@rafaellehmkuhl
Copy link
Member Author

For support, it would be nice to have the build date, and the tag to be a hyperlink to the changelog in github as we do in BlueOS.

Done!

@rafaellehmkuhl rafaellehmkuhl force-pushed the add-dynamic-version-to-about-page branch from d548e9c to 99a0d52 Compare November 22, 2024 16:30
@rafaellehmkuhl rafaellehmkuhl merged commit e03191c into bluerobotics:master Nov 25, 2024
10 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the add-dynamic-version-to-about-page branch November 25, 2024 14:42
@ES-Alexander
Copy link
Contributor

Relevant to #1245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: About page has hardcoded version
3 participants