add Mavftp service, read-only for now #926
Open
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
force-pushed
the
mavftp
branch
from
e768ae2
to
241b9a6
Compare
|
|
Williangalvani
force-pushed
the
mavftp
branch
3 times, most recently
from
fc9e4ce
to
112ab26
Compare
Williangalvani
changed the title
Williangalvani
force-pushed
the
mavftp
branch
2 times, most recently
from
046cdc0
to
b16dea5
Compare
Williangalvani
requested review from
patrickelectric,
joaoantoniocardoso and
JoaoMario109
patrickelectric
requested changes
Jun 20, 2024
3 tasks
Williangalvani
force-pushed
the
mavftp
branch
from
b16dea5
to
547ecd8
Compare
|
changed it so it gets code from pymavlink directly. currently WIP as we wait for the PR to be merged over there |
Williangalvani
force-pushed
the
mavftp
branch
2 times, most recently
from
240dccf
to
b04b92f
Compare
Williangalvani
force-pushed
the
mavftp
branch
from
b04b92f
to
474a6af
Compare
JoaoMario109
approved these changes
Oct 22, 2024
| argument=14555, | ||
| persistent=True, | ||
| protected=True, | ||
| ), |
There was a problem hiding this comment.
Can't we use one of our internal endpoints already ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help #457
thanks @ES-Alexander for the help =]
This adds a mavftp folder under ardupilot_logs
we should probably fix ArduPilot/ardupilot#23339 or just disable it if a navigator is running.
this is a heavily modified of https://github.com/ArduPilot/MAVProxy/blob/master/MAVProxy/modules/mavproxy_ftp.py
I added a fuse layer for it to work with the filelbrowser, and tried to better encapsulate functionality.
That said, I hate it. but it works.
I still think we should probably move this to a dedicated rust service later on.
I thought of using mavlink2rest, but I'm worried about the performance of assembling the arraybuffers from the jsons.
That would also go against my idea of upstreaming this to ardupilot eventually.
This could be further cleaned, but I'll open it for review to double-check this is path we want to follow.