Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DHCP range api and set server as default mode #2988

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Change DHCP range api and set server as default mode #2988

merged 2 commits into from
Nov 13, 2024

Conversation

patrickelectric
Copy link
Member

No description provided.

@patrickelectric
Copy link
Member Author

ping @Williangalvani @JoaoMario109

@patrickelectric patrickelectric merged commit 1eed1fc into bluerobotics:master Nov 13, 2024
6 checks passed
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Nov 25, 2024
@ES-Alexander ES-Alexander mentioned this pull request Dec 17, 2024
Merged
@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented labels Dec 19, 2024
@goasChris
Copy link

Does this mean that blueOS would act as a DHCP server on the default eth0 network? If that is the case, then that worries me a little bit, since we usually have an existing device there that does that already, and having two DHCP servers is usually not a great experience.

Or does it only kick in if it did not already get a DHCP lease from an existing DHCP server?

@patrickelectric
Copy link
Member Author

Does this mean that blueOS would act as a DHCP server on the default eth0 network? If that is the case, then that worries me a little bit, since we usually have an existing device there that does that already, and having two DHCP servers is usually not a great experience.

Or does it only kick in if it did not already get a DHCP lease from an existing DHCP server?

We could turn on the DHCP server if we fail to find one running on the network, I'll create an issue for that.

@patrickelectric patrickelectric mentioned this pull request Feb 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoMario109 JoaoMario109 JoaoMario109 approved these changes

@Williangalvani Williangalvani Awaiting requested review from Williangalvani

Assignees
No one assigned
Labels
docs-complete Change documentation has been completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrickelectric @goasChris @Williangalvani @JoaoMario109 @ES-Alexander