Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logfile name #2970

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Change logfile name #2970

merged 1 commit into from
Oct 20, 2024

Conversation

rotu
Copy link
Contributor

@rotu rotu commented Oct 18, 2024

  1. Remove dividers - these are unnecessary and the colon causes problems (fixes bug: logfile zip does not extract on Windows #2969)
  2. Switch order from month,day,year to year,month,day. This ensures correct collation when sorted

1. Remove dividers - these are unnecessary and the colon causes problems (bluerobotics#2969)
2. Switch order from month,day,year to year,month,day. This ensures correct collation when sorted
Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@voorloopnul @joaoantoniocardoso can this be a problem ?

@joaoantoniocardoso
Copy link
Member

@voorloopnul @joaoantoniocardoso can this be a problem ?

Definitely. Symbols are problematic for file names in general, and Windows is especially restrict about that.

@patrickelectric
Copy link
Member

@joaoantoniocardoso I'm talking about the log filename format itself. Changes will need to happen in our rust and cloud projects, no ?

@joaoantoniocardoso
Copy link
Member

joaoantoniocardoso commented Oct 20, 2024

@joaoantoniocardoso I'm talking about the log filename format itself. Changes will need to happen in our rust and cloud projects, no ?

Oh. MCM has a windows compatible filename, but also uses - as date separator. So the answer is: very likely yes

@rotu
Copy link
Contributor Author

rotu commented Oct 20, 2024

- is fine in a filename. I just removed it because I thought it didn't really serve a purpose and having both _ and - seemed messy.

I considered some variations like:
logfile_2024-12-31_23-59-59.log
logfile-20241231-235959.log
logfile_20241231T235959.log
20241231_235959.log

And I wound up liking logfile_20241231_235959.log best.

@patrickelectric patrickelectric merged commit c231098 into bluerobotics:master Oct 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: logfile zip does not extract on Windows
3 participants