Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker name validation logic #2939

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

rotu
Copy link
Contributor

@rotu rotu commented Oct 2, 2024

  1. Previously, valid tags such as 'myRegistry:5000/path/to/image' would be incorrectly rejected as containing a tag. Now private registries are tolerated.
  2. Previously, the validation would not work as intended, since it was missing boundary assertions to match the whole input.
  3. Previously, the path would permit capital letters.

@rotu
Copy link
Contributor Author

rotu commented Oct 2, 2024

Converting to draft since I have not yet tested this locally.

@rotu
Copy link
Contributor Author

rotu commented Oct 2, 2024

I was running into the same issues as docker has trying to build this locally:

135.6 WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'SSLError(SSLEOFError(8, '[SSL: UNEXPECTED_EOF_WHILE_READING] EOF occurred in violation of protocol (_ssl.c:1006)'))': /simple/python-dateutil/python_dateutil-2.9.0.post0-py2.py3-none-any.whl
141.1 ERROR: Could not install packages due to an OSError: HTTPSConnectionPool(host='www.piwheels.org', port=443): Max retries exceeded with url: /simple/python-dateutil/python_dateutil-2.9.0.post0-py2.py3-none-any.whl (Caused by SSLError(SSLEOFError(8, '[SSL: UNEXPECTED_EOF_WHILE_READING] EOF occurred in violation of protocol (_ssl.c:1006)')))

@patrickelectric
Copy link
Member

Hi @rotu any update on that ? Just wandering if this should be in draft still.

@rotu
Copy link
Contributor Author

rotu commented Oct 17, 2024

@patrickelectric In truth, I haven't been able to successfully build and deploy the blueos-core image on my pi 3B. (does uploading via the version chooser actually work for you?)

@rotu rotu marked this pull request as ready for review October 17, 2024 17:27
@patrickelectric
Copy link
Member

@patrickelectric In truth, I haven't been able to successfully build and deploy the blueos-core image on my pi 3B. (does uploading via the version chooser actually work for you?)

It works, but depends of swap and ram usage. I would recommend increasing you swapfile. Docker put everything in memory, the file and the uncompress version before installing. You can also install through the internet using your own GitHub fork as well. Our CI configuration work on our forks, you just need to setup the GitHub env variables.

@rotu
Copy link
Contributor Author

rotu commented Oct 18, 2024

No dice after increasing the swapfile to 2GB. AFAICT, it doesn't load the image to docker (docker image ls --all doesn't show the image on my pi) and then it restarts to "factory" version.
system_logs.zip

@rotu
Copy link
Contributor Author

rotu commented Oct 18, 2024

Okay, I was able to load the image by running the docker client locally against the remote docker host on the pi. So I think the "Manual upload" is just borked.

@rotu rotu marked this pull request as draft October 18, 2024 20:44
@rotu rotu marked this pull request as ready for review October 24, 2024 22:31
@rotu
Copy link
Contributor Author

rotu commented Oct 24, 2024

Alright. Finally tested this locally and caught a few bugs. I still could not get the manual uploader to work.

Anyway, you can test this with a fully qualified docker image name, like: index.docker.io:443/library/debian-slim. Or a completely unqualified name like debian-slim (though of course neither will work as BlueOS extensions as-is!).

@patrickelectric patrickelectric merged commit 3422be8 into bluerobotics:master Nov 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants