-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker name validation logic #2939
Conversation
rotu
commented
Oct 2, 2024
- Previously, valid tags such as 'myRegistry:5000/path/to/image' would be incorrectly rejected as containing a tag. Now private registries are tolerated.
- Previously, the validation would not work as intended, since it was missing boundary assertions to match the whole input.
- Previously, the path would permit capital letters.
Converting to draft since I have not yet tested this locally. |
I was running into the same issues as docker has trying to build this locally:
|
Hi @rotu any update on that ? Just wandering if this should be in draft still. |
@patrickelectric In truth, I haven't been able to successfully build and deploy the blueos-core image on my pi 3B. (does uploading via the version chooser actually work for you?) |
It works, but depends of swap and ram usage. I would recommend increasing you swapfile. Docker put everything in memory, the file and the uncompress version before installing. You can also install through the internet using your own GitHub fork as well. Our CI configuration work on our forks, you just need to setup the GitHub env variables. |
No dice after increasing the swapfile to 2GB. AFAICT, it doesn't load the image to docker ( |
Okay, I was able to load the image by running the docker client locally against the remote docker host on the pi. So I think the "Manual upload" is just borked. |
…h component *AND* a valid domain!
Alright. Finally tested this locally and caught a few bugs. I still could not get the manual uploader to work. Anyway, you can test this with a fully qualified docker image name, like: |