Replace MessageArea with standard Gtk.InfoBar #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Put ApplicationWindow in builder * Use the Gtk.Grid for all layout * Drop icon widgets and use icon names
The progressbar is lager than the stats and it would cause the box to resize. Give it enough space by requesting at least 24px.
infirit
force-pushed
the
dropmessagearea
branch
3 times, most recently
from
a847748 to
324a549
Compare
infirit
force-pushed
the
dropmessagearea
branch
2 times, most recently
from
39c6690 to
cab6e81
Compare
cschramm
previously approved these changes
Jul 11, 2022
A Gtk.InfoBar already has a Gtk.Revealer which animates perfectly fine for our use.
|
Kudos, SonarCloud Quality Gate passed!
|
cschramm
approved these changes
Jul 17, 2022
cschramm
added a commit
to cschramm/blueman
that referenced
this pull request
May 10, 2024
It was somehow dropped in blueman-project#1776.
infirit
pushed a commit
to cschramm/blueman
that referenced
this pull request
May 15, 2024
It was somehow dropped in blueman-project#1776.
infirit
pushed a commit
to cschramm/blueman
that referenced
this pull request
May 15, 2024
It was somehow dropped in blueman-project#1776.
cschramm
added a commit
that referenced
this pull request
May 15, 2024
It was somehow dropped in #1776.
infirit
pushed a commit
to infirit/blueman
that referenced
this pull request
May 15, 2024
It was somehow dropped in blueman-project#1776.
infirit
pushed a commit
to infirit/blueman
that referenced
this pull request
May 17, 2024
It was somehow dropped in blueman-project#1776.
infirit
pushed a commit
to infirit/blueman
that referenced
this pull request
Sep 19, 2024
It was somehow dropped in blueman-project#1776.
infirit
pushed a commit
that referenced
this pull request
Sep 27, 2024
It was somehow dropped in #1776.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't really need one, Gtk.InfoBar has everything we need already. The rest is a small fix and rework.