Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Attempts to fix: https://github.com/bluelabsio/s3-stream/issues/2 #7

Closed
wants to merge 1 commit into from

Conversation

hderms
Copy link

@hderms hderms commented Jul 13, 2016

What

Add a metadata class to the relevant signatures so that we can set contentType in the initial HTTP request to amazon. Metadata is being passed instead of just contentType to make way for more options to be set in the future

Why

  • Setting the ContentType can be important for various application use-cases and having to perform subsequent HTTP requests to set it is not in the spirit of efficiency that a streaming library should strive for.
  • Allow setting Content-Type on Upload #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants