Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo to README #72

Merged
merged 9 commits into from
Jun 10, 2020
Merged

Add logo to README #72

merged 9 commits into from
Jun 10, 2020

Conversation

vinceatbluelabs
Copy link
Contributor

@vinceatbluelabs vinceatbluelabs commented Jun 5, 2020

@@ -1,4 +1,6 @@
# Records Mover - mvrec
<img
src="https://raw.githubusercontent.com/bluelabsio/records-mover/add_logo/docs/records-mover-horizontal.png"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • TODO: Update URL to point to master.

@@ -1 +1 @@
5
8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right with both a banner image and a top-level markdown header, but markdownlint both really doesn't want raw HTML and also doesn't want a missing top-level markdown header. Oh well.

@vinceatbluelabs vinceatbluelabs changed the title Add logo Add logo to README Jun 9, 2020
@vinceatbluelabs vinceatbluelabs requested a review from cwegrzyn June 9, 2020 13:51
@vinceatbluelabs vinceatbluelabs marked this pull request as ready for review June 9, 2020 13:51
Copy link
Contributor

@cwegrzyn cwegrzyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Probably worth adding any other assets we can now (e.g., if there are vector versions, etc) so they don't get lost.

@vinceatbluelabs vinceatbluelabs merged commit 783fa7e into master Jun 10, 2020
@vinceatbluelabs vinceatbluelabs deleted the add_logo branch June 10, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants