-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logo to README #72
Conversation
@@ -1,4 +1,6 @@ | |||
# Records Mover - mvrec | |||
<img | |||
src="https://raw.githubusercontent.com/bluelabsio/records-mover/add_logo/docs/records-mover-horizontal.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- TODO: Update URL to point to master.
@@ -1 +1 @@ | |||
5 | |||
8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right with both a banner image and a top-level markdown header, but markdownlint both really doesn't want raw HTML and also doesn't want a missing top-level markdown header. Oh well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Probably worth adding any other assets we can now (e.g., if there are vector versions, etc) so they don't get lost.
See https://github.com/bluelabsio/records-mover/blob/add_logo/README.md for the experience!