Allow configuration to be set for session type #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow folks using custom cred types (like LastPass!) to configure this globally via config files.
vinceatbluelabs
commented
May 30, 2020
| @@ -96,7 +96,7 @@ URL or configure a TOML-style file in one of the following locations: | |||
|
|
|||
| Example file: | |||
|
|
|||
| ```toml | |||
| ```ini | |||
There was a problem hiding this comment.
Turns out config_resolver uses https://docs.python.org/3/library/configparser.html which uses a simplified INI format which is not actually TOML. TIL!
vinceatbluelabs
commented
May 30, 2020
| @@ -109,3 +109,72 @@ downloaded for local processing) will be stored per Python's | |||
| which allow for configuration via the `TMPDIR`, `TEMP` or `TMP` env | |||
| variables, and generally default to | |||
| [something reasonable per your OS](https://docs.python.org/3/library/tempfile.html#tempfile.gettempdir). | |||
|
|
|||
| ## Cloud credentials (e.g., S3/GCS/Google Sheets) | |||
There was a problem hiding this comment.
Since database credentials come out of db-facts, the major difference made in switching the default creds provider from CredsViaLastPass and CredsViaEnv is how non-default GCP credentials are passed--this text should address that and help provide guidance.
cwegrzyn
approved these changes
May 31, 2020
| cfg = config_result.config | ||
| if 'session' in cfg: | ||
| session_cfg = cfg['session'] | ||
| session_type: Optional[str] = session_cfg.get('session_type') |
There was a problem hiding this comment.
Could creds_type be a more appropriate name here? Does this control anything about the session other than how it gets the creds?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow folks using custom cred types (like LastPass!) to configure this globally via config files. Combined with #69 this will allow enterprise uses to be configured while more generic settings are used by default.