Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db_connect_method -> exports_from #60

Merged
merged 2 commits into from
May 11, 2020
Merged

db_connect_method -> exports_from #60

merged 2 commits into from
May 11, 2020

Conversation

vinceatbluelabs
Copy link
Contributor

@vinceatbluelabs vinceatbluelabs commented May 10, 2020 •
edited
Loading

Per discussion on https://app.asana.com/0/1128138765527694/1158018798773355

The build here won't work until bluelabsio/db-facts#23 is merged and published.

@vinceatbluelabs vinceatbluelabs requested a review from cwegrzyn May 10, 2020 14:32
@vinceatbluelabs vinceatbluelabs changed the title db_connect_method -> exports_from WIP: db_connect_method -> exports_from May 10, 2020
@vinceatbluelabs vinceatbluelabs changed the title WIP: db_connect_method -> exports_from db_connect_method -> exports_from May 11, 2020
cwegrzyn
cwegrzyn approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@cwegrzyn cwegrzyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@vinceatbluelabs vinceatbluelabs merged commit d23ae4d into master May 11, 2020
@vinceatbluelabs vinceatbluelabs deleted the db_connect_method_retirement branch May 11, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwegrzyn cwegrzyn cwegrzyn approved these changes

@crvena-sonja crvena-sonja Awaiting requested review from crvena-sonja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinceatbluelabs @cwegrzyn