Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM-114 remove upper bounds on db-facts #266

Merged
merged 4 commits into from
Dec 12, 2023
Merged

RM-114 remove upper bounds on db-facts #266

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f1d6ad
RM-112 remove upper bound oauth2client
ryantimjohn Dec 11, 2023
a951a16
RM-113 remove upper bound pyyaml
ryantimjohn Dec 11, 2023
db46f0e
RM-114 remove upper bounds on db-facts
ryantimjohn Dec 11, 2023
f5fd814
Merge branch 'main' into RM-114-remove-upper-bound-on-db-facts
Brunope Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ def initialize_options(self) -> None:
gsheet_dependencies = [
'google',
'google_auth_httplib2',
'oauth2client>=2.0.2,<2.1.0',
'oauth2client>=2.0.2',
'PyOpenSSL'
] + google_api_client_dependencies

Expand Down Expand Up @@ -298,18 +298,8 @@ def initialize_options(self) -> None:
},
install_requires=[
'timeout_decorator',
# awscli pins PyYAML. We have seen issues at
# run-time if we don't constrain things here as well. So
# this tracks the awscli req for python >= 3.6 which is
# what we support
#
# https://github.com/aws/aws-cli/blob/develop/setup.py
# #### NEW UNFORTUNATE CONSTRAINTS #####
# https://github.com/yaml/pyyaml/issues/724
'PyYAML>=3.10,<=5.3.1',
# Not sure how/if interface will change in db-facts, so
# let's be conservative about what we're specifying for now.
'db-facts>=4,<5',
'PyYAML>=3.10',
'db-facts>=4',
# Version 4.0.0 is not yet compatible with requests, and pip
# 20.3 is not smart enough to pay attention to that,
# resulting in runtime complaints. Can be removed once 20.4
Expand Down