Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM-108 remove upper bound on google-api-python-cli #259

Merged

Conversation

ryantimjohn
Copy link
Contributor

No description provided.

RM-108 remove upper bound on google-api-python-cli

RM-108
@ryantimjohn ryantimjohn force-pushed the RM-108-remove-upper-bound-on-google-api-python-client branch from 677e00e to 7a45e95 Compare December 4, 2023 21:20
@ryantimjohn ryantimjohn marked this pull request as ready for review December 4, 2023 21:57
@@ -105,7 +105,7 @@ def initialize_options(self) -> None:
# 'googleapiclient.discovery.build':
#
# https://github.com/googleapis/google-auth-library-python/issues/190
'google-api-python-client>=1.8.0,<1.9.0',
'google-api-python-client>=1.8.0',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a <2 is in order here for future proofing?

@Brunope
Copy link
Collaborator

Brunope commented Dec 4, 2023

what is the context behind this change?

@ryantimjohn
Copy link
Contributor Author

@Brunope, to @naswierczek 's point, it's now becoming accepted wisdom in Python package distribution to remove all upper bounds on required packages, then have a system like we do with daily builds + making future warnings trigger failures to catch errors early, then build compatibility with newest package versions wherever possible. Break early and fix. This gives your package the least likelihood of having dependency incompatibilities with other packages that people need in their workflows. Only where there's a genuine inability to make your package incompatible with most recent versions should you have upper bounds.

I'm going through all of our upper bounds now one-by-one and seeing if we can reasonably remove them.

Here's an article about this:
https://iscinumpy.dev/post/bound-version-constraints/

@ryantimjohn
Copy link
Contributor Author

Screenshot 2023-12-11 at 11 12 56 AM
@naswierczek why'd you remove you supportive comment =p

@naswierczek
Copy link
Contributor

naswierczek commented Dec 11, 2023

@ryantimjohn I certainly didn't do it on purpose! I don't know why the comment got removed!

I still support removing bounds unless we know something will break. If we have to stay on an old version for reasons, we should keep any upper bounds we have. Otherwise if an upper bound can be removed it should be. :)

@ryantimjohn ryantimjohn added this pull request to the merge queue Dec 11, 2023
Merged via the queue into main with commit e6f03f7 Dec 11, 2023
28 checks passed
@ryantimjohn ryantimjohn deleted the RM-108-remove-upper-bound-on-google-api-python-client branch December 18, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants