-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RM-108 remove upper bound on google-api-python-cli #259
RM-108 remove upper bound on google-api-python-cli #259
Conversation
RM-108 remove upper bound on google-api-python-cli RM-108
677e00e
to
7a45e95
Compare
@@ -105,7 +105,7 @@ def initialize_options(self) -> None: | |||
# 'googleapiclient.discovery.build': | |||
# | |||
# https://github.com/googleapis/google-auth-library-python/issues/190 | |||
'google-api-python-client>=1.8.0,<1.9.0', | |||
'google-api-python-client>=1.8.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe a <2
is in order here for future proofing?
what is the context behind this change? |
@Brunope, to @naswierczek 's point, it's now becoming accepted wisdom in Python package distribution to remove all upper bounds on required packages, then have a system like we do with daily builds + making future warnings trigger failures to catch errors early, then build compatibility with newest package versions wherever possible. Break early and fix. This gives your package the least likelihood of having dependency incompatibilities with other packages that people need in their workflows. Only where there's a genuine inability to make your package incompatible with most recent versions should you have upper bounds. I'm going through all of our upper bounds now one-by-one and seeing if we can reasonably remove them. Here's an article about this: |
|
@ryantimjohn I certainly didn't do it on purpose! I don't know why the comment got removed! I still support removing bounds unless we know something will break. If we have to stay on an old version for reasons, we should keep any upper bounds we have. Otherwise if an upper bound can be removed it should be. :) |
No description provided.