-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RM-105: Adding Dockerfile #257
Conversation
naswierczek
commented
Nov 7, 2023
- This will build a container and run all non-integration tests for records-mover
68dbd02
to
540e5e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naswierczek this looks great!
You have a quality job failing: https://app.circleci.com/pipelines/github/bluelabsio/records-mover/3639/workflows/8bb8e207-4583-4766-8991-f9828032bcfd/jobs/48579/parallel-runs/0/steps/0-103
Clean up the additional errors on the MD Linter that you additions added and you should be good to commit!
Additionally, it might be worth us figuring out an auto-formatter instead of a linter so that we don't have to worry about silly errors like these delaying deploying code.
2da75c8
to
ceb4329
Compare
@ryantimjohn Please review and remove your request for changes when you get a chance! :) |
ceb4329
to
9f37451
Compare
9f37451
to
cf735c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, sorry, I'm getting an error trying to build this:
> [7/7] RUN python -m venv venv && . venv/bin/activate && pip install --upgrade pip && pip install --progress-bar=off -r requirements.txt && pip install --upgrade --progress-bar=off 'pandas>=1.5.3,<2' && pip install -e '.[unittest,typecheck]' #:
#10 0.321 + python -m venv venv
#10 0.407 Error: [Errno 2] No such file or directory: '/records-mover/venv/bin/python'
------
executor failed running [/bin/bash -exo pipefail -c python -m venv venv && . venv/bin/activate && pip install --upgrade pip && pip install --progress-bar=off -r requirements.txt && pip install --upgrade --progress-bar=off 'pandas>=1.5.3,<2' && pip install -e '.[unittest,typecheck]' #]: exit code: 1
@naswierczek I think I understand what happened, I think you need to add a |
- This will build a container and run all non-integration tests for records-mover - Added docker-compose to make life simpler - includes .dockerignore to exclude generated artifacts (copy-pasta of .gitgnore) - Updating .gitignore
cf735c0
to
b8ecafb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for addressing all concerns so thoughtfully!