use composition in RM-87 #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantimjohn
force-pushed
the
RM-87-Upgrade-to-SQLAlchemy-2.0
branch
from
f22acfd to
d9534d8
Compare
ryantimjohn
merged commit 182502d
into
RM-87-Upgrade-to-SQLAlchemy-2.0
4 of 5 checks passed
ryantimjohn
deleted the
use-composition-in-RM-87-Upgrade-to-SQLAlchemy-2.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @Brunope 's comment here:
#245 (comment)
I don't want to create some weird inheritance hierarchy, but thought it might make sense to use the spirit of Composition Over Inheritance and just have some methods we can import to use in these functions. Of course, this isn't strictly composition since it doesn't use another class to implement those methods.