Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm 95 remove sql injection possibilities #254

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

ryantimjohn
Copy link
Contributor

No description provided.

RM-95 use Table

Revert "RM-95 builtin has_table"

This reverts commit 43edb5e.

RM-95 builtin has_table

RM-95 remove unused ignore

RM-95 add if_exists=True

RM-95 use DropTable

RM-95 use DropTable

RM-95 use DropTable

RM-95 update ignore

RM-95 update ignore

RM-95 add newline

RM-95 use target.

RM-95 update text expectation

RM-95 update to DropTable

RM-95 ignore arg-type

RM-95 add space afterward

RM-95 use newline

RM-95 update select statement

RM-95 update mock names to strings

RM-95 select '*' from table

RM-95 explicitly use select *

RM-95 re-add quote_schema_and_table

RM-95 add newline

RM-95 use table.select

RM-95 fix test drop table

RM-95 use DropTable

RM-95 bind connection for drop

RM-95 update to use table.drop

RM-95 remove mock_schema_and_table ref

RM-95 update to use DELETE command

RM-95 add mock schema name and table name
@ryantimjohn ryantimjohn force-pushed the RM-95-Remove-SQL-injection-possibilities branch from 0bd2b5f to 3f8383a Compare October 30, 2023 17:07
RM-95 address Flake quality issue

RM-95 quote tables

RM-95 add db argument

RM-95 use quote_schema_and_table

RM-95 use quote_schema_and_table

Revert "RM-95 use quoted schema and table"

This reverts commit 4404d75.

RM-95 use quoted schema and table

RM-95 use quoted schema and table

RM-95 manually remove backticks

RM-95 update test to use table_obj

RM-95 update to use table object

RM-95 redshift_db_driver to use sqlalchemy-priv

RM-95 fix typecheck

RM-95 update driver to user sqlalchemy priv

RM-95 add sqlalchemy privileges for priv mngmnt

RM-95 remove autoload_with

RM-95 add where TRUE to delete

RM-95 fix flake8 errors

RM-95 remove autoload_with

RM-95 update to use table_obj

RM-95 update typing
@ryantimjohn ryantimjohn force-pushed the RM-95-Remove-SQL-injection-possibilities branch from 24adf66 to 1308686 Compare November 6, 2023 22:19
@ryantimjohn ryantimjohn marked this pull request as ready for review November 6, 2023 22:25
@ryantimjohn ryantimjohn requested a review from Brunope November 6, 2023 22:25
@ryantimjohn
Copy link
Contributor Author

@Brunope should be ready for review at the end of testing! (I just merged in main.)

records_mover/db/driver.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Brunope Brunope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had some minor concerns but will defer to you

@ryantimjohn ryantimjohn force-pushed the RM-95-Remove-SQL-injection-possibilities branch from e76ed1a to 4dbf0fe Compare November 20, 2023 18:48
@ryantimjohn ryantimjohn merged commit b73a366 into main Nov 20, 2023
4 of 27 checks passed
@ryantimjohn ryantimjohn deleted the RM-95-Remove-SQL-injection-possibilities branch November 20, 2023 18:48
@ryantimjohn ryantimjohn restored the RM-95-Remove-SQL-injection-possibilities branch November 20, 2023 18:50
@ryantimjohn ryantimjohn deleted the RM-95-Remove-SQL-injection-possibilities branch November 20, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants