-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rm 95 remove sql injection possibilities #254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RM-95 use Table Revert "RM-95 builtin has_table" This reverts commit 43edb5e. RM-95 builtin has_table RM-95 remove unused ignore RM-95 add if_exists=True RM-95 use DropTable RM-95 use DropTable RM-95 use DropTable RM-95 update ignore RM-95 update ignore RM-95 add newline RM-95 use target. RM-95 update text expectation RM-95 update to DropTable RM-95 ignore arg-type RM-95 add space afterward RM-95 use newline RM-95 update select statement RM-95 update mock names to strings RM-95 select '*' from table RM-95 explicitly use select * RM-95 re-add quote_schema_and_table RM-95 add newline RM-95 use table.select RM-95 fix test drop table RM-95 use DropTable RM-95 bind connection for drop RM-95 update to use table.drop RM-95 remove mock_schema_and_table ref RM-95 update to use DELETE command RM-95 add mock schema name and table name
ryantimjohn
force-pushed
the
RM-95-Remove-SQL-injection-possibilities
branch
from
October 30, 2023 17:07
0bd2b5f
to
3f8383a
Compare
RM-95 address Flake quality issue RM-95 quote tables RM-95 add db argument RM-95 use quote_schema_and_table RM-95 use quote_schema_and_table Revert "RM-95 use quoted schema and table" This reverts commit 4404d75. RM-95 use quoted schema and table RM-95 use quoted schema and table RM-95 manually remove backticks RM-95 update test to use table_obj RM-95 update to use table object RM-95 redshift_db_driver to use sqlalchemy-priv RM-95 fix typecheck RM-95 update driver to user sqlalchemy priv RM-95 add sqlalchemy privileges for priv mngmnt RM-95 remove autoload_with RM-95 add where TRUE to delete RM-95 fix flake8 errors RM-95 remove autoload_with RM-95 update to use table_obj RM-95 update typing
ryantimjohn
force-pushed
the
RM-95-Remove-SQL-injection-possibilities
branch
from
November 6, 2023 22:19
24adf66
to
1308686
Compare
@Brunope should be ready for review at the end of testing! (I just merged in main.) |
Brunope
reviewed
Nov 13, 2023
Brunope
reviewed
Nov 13, 2023
Brunope
reviewed
Nov 13, 2023
Brunope
reviewed
Nov 13, 2023
Brunope
reviewed
Nov 13, 2023
Brunope
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had some minor concerns but will defer to you
RM-95 quality fix
ryantimjohn
force-pushed
the
RM-95-Remove-SQL-injection-possibilities
branch
from
November 20, 2023 18:48
e76ed1a
to
4dbf0fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.