RM-96-rewrite-DBDriver-so-current-db-becomes-a-connection-db_engine-takes-all-Engine-responsibilities #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change build fail slack channel
release v1.5.4
…river-so-current-db-becomes-a-connection-db_engine-takes-all-Engine-responsibilities
RM-96 update records_hook RM-96 use check_db_conn_engine RM-96 rewrite driver interface RM-96 rewrite driver interface RM-96 fix flake errors RM-96 update flake8 metrics RM-96 only quote when in TYPE_CHECKING RM-96 make session dbdrive optional args RM-96 don't call warnings RM-96 update bigquery loader interface RM-96 update bigquery unloader interface RM-96 update quote call RM-96 update db_driver calls RM-96 set db arg to optional RM-96 use db_conn RM-96 add visibility for when db_engine created RM-96 return db, db_conn, db_engine RM-96 use db_conn RM-96 update quote_schema_and_table calls RM-96 execute text RM-96 wrap in text RM-96 call with named db_engine RM-96 use lazy initialization for db_conn RM-96 pass connection instead of engine RM-96 use lazy initialization RM-96 replace db.dialect with db_engine.dialect RM-96 put space after schema_and_table RM-96 pass params as dict RM-96 use db_engine RM-96 use db_engine RM-96 use db_engine RM-96 set conn_opened_here in init RM-96 close connection within destructor RM-96 use logging statements RM-96 remove whitespace RM-96 use db_engine RM-96 remove super db_conn RM-96 set to db_conn RM-96 specify db_conn RM-96 pass self.db_conn RM-96 pass db_engine not conn RM-96 pass args correctly RM-96 standardize calling RM-96 Fix call RM-96 fix order of args RM-96 fix call RM-96 fix call RM-96 fix call RM-96 fix call RM-96 fix quote schema and table calls RM-96 fix quoting RM-96 fix grant permissions RM-96 fix set_grant_permissions_for_groups calls RM-96 fix quote group name RM-96 fix set_grant_permissions_for_users RM-96 fix movk quote call RM-96 fix db_conn calls RM-96 fix quoting RM-96 fix bigquery test call RM-96 pass db_engine RM-96 fix quoting RM-96 update quote value RM-96 fix quote value RM-96 fix quote function RM-96 fix quote_table_only RM-96 allow on the spot spinning up of conns RM-96 fix Bigquery loader RM-96 fix bq loader RM-96 fix bq test RM-96 fix bq invok RM-96 fix bigquery loader issues RM-96 fix mysqlLoader RM-96 fix mock mysql RM-96 fix postgres loader RM-96 fix postgres loader RM-96 allow engine to connect RM-96 fix postgresloader RM-96 fix table call RM-96 autoload with mock_db engine RM-96 load with engine RM-96 fix postgres unloader RM-96 use db_conn RM-96 fix redshift loader RM-96 fix unloader RM-96 fix conn RM-96 simplify db call fix postgres loader RM-96 use db_conn RM-96 pass none RM-96 pass None db RM-96 fix schema sql RM-96 fix set_grant_perms call RM-96 pass none to db RM-56 don't enter RM-96 pass db_conn RM-96 pass None to db RM-96 pass connection instead RM-96 update unloader call RM-96 remove db_engine from null_schema_quoter RM-96 fix call to null schema and simple value RM-96 make db_engine optional RM-96 fix loader call RM-96 fix unloader calls RM-96 fix vertica db driver call RM-96 fix unloader call RM-96 fix unload call RM-96 fix unloader call RM-96 convert action to string RM-96 fix db call RM-96 fix export objects call RM-96 fix vertica driver test Revert "RM-96 fix vertica driver test" This reverts commit 3581ff6. Revert "RM-96 fix export objects call" This reverts commit 65fc54c. RM-96 revert to EXPORT OBJECTS Revert "Revert "RM-96 fix vertica driver test"" This reverts commit 349ea74. RM-96 use db_conn and db_engine RM-96 fix quote schema and table RM-96 name db_engine RM-96 use db_conn RM-96 use db_conn RM-96 use magicmock RM-96 remove db_driver and use db_conn RM-96 use db_engine conns RM-96 pass a db_engine RM-96 make schema sql a string RM-96 add string method to mock_schema_sql RM-96 use magicMock for builtins RM-96 pass string RM-96 make mock_conn correct RM-96 try begin RM-96 print calls RM-96 print execute mock calls RM-96 print connection object RM-96 wrap drop table sql in text RM-96 print call_args_list RM-96 print execute.call_args RM-96 print call args RM-96 try no return value on connect RM-96 compare string args RM-96 use second arg RM-96 see all call_args RM-96 pull out args RM-96 make sure conn objects are the same RM-96 print args RM-96 pull our drop table mock schema str args RM-96 move from exec_schema_sql to execute text RM-96 pass mock_conn RM-96 fix mock schema sql calls RM-96 fix mock_conns RM-96 call mock_driver.db_engine RM-96 fix RM-96 replace mock_driver RM-96 replace mock_driver RM-96 use str args RM-96 get return value RM-96 use mock_db_engine RM-96 use mock_db_conn RM-96 use db_conn RM-96 pull db_engine RM-96 use db_engine call RM-96 make equal to db_engine RM-96 use db_engine RM-96 use db_conn RM-96 use db_conn RM-96 use db_conn RM-96 use db_conn RM-96 use db_conn RM-96 use db_engine RM-96 don't use db_conn RM-96 use lazy initialization for db_conn RM-96 add conn_opened_here RM-96 update mysqlloader RM-96 use db_engine RM-96 use db_conn RM-96 pass None for db RM-96 pass db_conn RM-96 pass none for DB RM-96 go back to old order of args RM-96 pass db_conn RM-96 make optional RM-96 ignore union-attr RM-96 ignore union-attr RM-96 ignore union-attr RM-96 ignore union-attr RM-96 make db args optional RM-96 add Optional import RM-96 make db_conn and db_engine Optional RM-96 import optional RM-96 add space RM-96 use DBDRIVER protocol RM-96 fix typo RM-96 use db driver as type RM-96 try to use db-driver RM-96 revert db argument to mandatory RM-96 pass None as db RM-96 add DRDriver Initialization protocol RM-96 use DBDriverInitialization RM-96 import DBDriverInitialization protocol RM-96 make db mandatory RM-96 pass None to db RM-96 pass unquoted RM-96 revert DBDriver Initialization protocol RM-96 quote types, union None RM-96 Union None RM-96 remove union None RM-96 quote DBDriver RM-96 pass db RM-96 pass None to db RM-96 pass None as db arg RM-96 pass None as db RM-96 pass None to driver db RM-96 assert callend with None RM-96 assert called with None RM-96 make db optional RM-96 pass db driver as callable RM-96 use optional instead of Union None RM-96 ignore call-arg RM-96 add type hinting check_db_conn_engine RM-96 update return RM-96 remove type ignores RM-96 ignore return value RM-96 remove unused ignore RM-96 make db Optional RM-96 close db_conn not _db_conn RM-96 account for no db_conn RM-96 revert db to mandatory RM-96 make type optional, no None default RM-96 make db optional RM-96 make db mandatory RM-96 make db optional RM-96 remove default db argument RM-96 pass None to db RM-96 make db mandatory RM-96 make db mandatory RM-96 pass db RM-96 initialize connection if None RM-96 use abstractmethod decorator RM-96 pass callable RM-96 pass db_conn and db_engine RM-96 ignore call-arg RM-96 call db_engine.connect() RM-96 pass named args RM-96 expect named args RM-96 pass named args db and db_conn Revert "RM-96 pass callable" This reverts commit fa6c1b2. Revert "RM-96 use abstractmethod decorator" This reverts commit 5a2c74a. RM-96 move ignore RM-96 None default args RM-96 remove unused ignores RM-96 pass db argument RM-96 remove upper bound on PyYAML RM-96 upgrade setuptools, leave max pyyaml RM-96 max Pyyaml, revert setuptools RM-96 pass db as None RM-96 pass named arguments db and db_engine RM-96 call with named args RM-96 inspect if has table RM-96 use SA instance RM-96 assert correct function called RM-96 pass args as dictionary RM-96 force sqlalchemy 2.0 RM-96 remove upper bound on sqlalchemy redshift Revert "RM-96 force sqlalchemy 2.0" This reverts commit 2e62ea7. RM-96 log what object is creating the connection RM-96 pass connection to db_driver RM-96 pass variable not attribute RM-96 close connection after fixture teardown RM-96 bring numeric fix teardown into teardown RM-96 don't begin the connection RM-96 use connection.begin() RM-96 pass db_conn RM-96 check if connection closed before closing RM-96 remove super of tearDown RM-96 bypass teardown with redshift RM-96 remove close connection logging RM-96 remove tearDown RM-96 kill tearDown RM-96 override tearDown RM-96 remove super.tearDown RM-96 override tearDown RM-96 run tbl-2-tbl with pytest RM-96 pass params as dictionary Revert "RM-96 run tbl-2-tbl with pytest" This reverts commit e5d1a52. RM-96 use self.db_engine RM-96 pass db_conn not self.db_conn RM-96 pass all args to PostgresUnloader RM-96 separate tests into classes RM-96 try closing all sessions RM-96 dispose of engine RM-96 bring teardown into method Revert "RM-96 bring teardown into method" This reverts commit b596203. Revert "RM-96 dispose of engine" This reverts commit 07b117d. Revert "RM-96 try closing all sessions" This reverts commit 8614588. Revert "RM-96 separate tests into classes" This reverts commit 9bd0278. RM-96 pass connection to table method RM-96 update sources factory RM-96 close connection in teardown RM-96 close connection RM-96 pass connection to recordsdatetimefixture RM-96 pass self.connection RM-96 remove self.connection.begin RM-96 remove db_conn.begin RM-96 tear down datetime fixture RM-96 drop tables before closing connection RM-96 remove db_conn.begin RM-96 pass engine to quote value RM-96 update quote value call RM-96 update quote value call RM-96 fix type errors RM-96 convert table2table to pytest RM-96 fix spelling RM-96 pass args as tuples RM-96 parametrize within class body RM-96 use parameterized RM-96 from param import param RM-96 get db_names RM-96 configure parameterize RM-96 pass and close connection RM-96 pass db_conn RM-96 put Connection in quotes RM-96 move up assignment of db_conn RM-96 comment out teardown RM-96 increase verbosity including fixtures RM-96 fixtures less verbose RM-96 update dir for old sqlalchemy RM-96 pytest -verbose RM-96 uncomment teardown RM-96 comment out tear down RM-96 update to pass db_conn=None RM-96 update cache RM-96 fix mypy RM-96 fix mypy errors RM-96 fix mypy RM-96 remove 3.7 RM-96 remove 3.7 RM-96 add db_conn param RM-96 don't process ForwardRef RM-96 add docstring for db_conn RM-96 begin connection before executing RM-96 use self.connection RM-96 trigger build RM-96 fix quality issues RM-96 add flak8 noqa
ryantimjohn
force-pushed
the
RM-96-rewrite-DBDriver-so-current-db-becomes-a-connection-db_engine-takes-all-Engine-responsibilities
branch
from
692a756 to
4aea0c0
Compare
ryantimjohn
deleted the
RM-96-rewrite-DBDriver-so-current-db-becomes-a-connection-db_engine-takes-all-Engine-responsibilities
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.