Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM-86 Error on Future and Deprecation Warnings #244

Merged
merged 16 commits into from
May 23, 2023

Conversation

ryantimjohn
Copy link
Contributor

@ryantimjohn ryantimjohn commented May 9, 2023

We now have a nightly build. We'd like that to fail on Future and Deprecation Warnings so that we correct them before they mess up someone's install.

…nd-above-and-below-2.0.0' into RM-86-Build-in-Deprecation-warning-failures
@ryantimjohn ryantimjohn force-pushed the RM-86-Build-in-Deprecation-warning-failures branch 5 times, most recently from 2d579af to 9c227b6 Compare May 16, 2023 00:51
RM-86 switch to only testing records_mover package

RM-86 sqlalchemy

RM-86 redshift_sqlalchemy

RM-86 try dash in module name

RM-86 exempt sqlalchemy redshift

RM-86 add explicit callout for google

RM-86 add exception for pkg_resources

RM-86 update req version to get rid of pip err

RM-86 move pytest.ini to main folder

RM-86 move config to pytest.ini

RM-86 update URL method call

RM-86 have fail on all dep and future

RM-86 try regex

RM-86 add wildcards around recordsmover

RM-86 add FutureWarning failure

RM-86 add Deprecation fail to config

RM-86 Remove SADeprecation Warning

RM-86 error on SADeprecationWarning

RM-86 update cache location

RM-86 simpler warning filter

RM-86 try different filtering

RM-86 try multiple option flags

RM-86 except warnings from outside packages
RM-86 silence SA 2.0 warning (separate ticket)
Revert "RM-86 remove use of prefix arg"

This reverts commit 0692753.

RM-86 remove instances of untitled_ prefix

RM-86 try int index

RM-86 revert column names

RM-86 try unnamed rather than untitled

RM-86 check for column datatype

RM-86 print columns
RM-86 lower mypy high water mark
@ryantimjohn ryantimjohn force-pushed the RM-86-Build-in-Deprecation-warning-failures branch from 9c227b6 to 749b1bb Compare May 16, 2023 00:52
@ryantimjohn ryantimjohn changed the title Rm 86 build in deprecation warning failures RM-86 Error on Future and Deprecation Warnings May 16, 2023
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Brunope especially for your visibility, this pytest.ini is what makes the pytest command error on Deprecation and Future warning

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Brunope especially for your visibility, this pytest.ini is what makes the pytest command error on Deprecation and Future warning

@ryantimjohn ryantimjohn marked this pull request as ready for review May 16, 2023 01:08
@ryantimjohn ryantimjohn requested a review from Brunope May 22, 2023 21:36
@ryantimjohn ryantimjohn added this pull request to the merge queue May 23, 2023
Merged via the queue into main with commit 77173f4 May 23, 2023
@ryantimjohn ryantimjohn deleted the RM-86-Build-in-Deprecation-warning-failures branch May 23, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants