RM-44 Wrap determine_input_date_order_style in a handler object #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I run the |
Brunope
commented
Apr 18, 2023
| @@ -1 +1 @@ | |||
| 90.6000 | |||
| 89.7400 | |||
There was a problem hiding this comment.
I'm not sure why the coverage had to go down, to me it looks like everything is appropriately type hinted?
ryantimjohn
reviewed
Apr 24, 2023
ryantimjohn
reviewed
Apr 24, 2023
This is bizarre... maybe different python version and compiles to different underlying number of lines? |
The handler stores state as it processes and removes the various hints, rather than computing it all in one big function.
Brunope
force-pushed
the
RM-44-date-input-style-too-complex
branch
from
8d9ee95 to
5403ede
Compare
ryantimjohn
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handler stores state as it processes and removes the various hints, rather than computing it all in one big function.