Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RM-74 ignore fileobject type for mypy typecheck #238

Merged
merged 1 commit into from
Apr 10, 2023
Merged

RM-74 ignore fileobject type for mypy typecheck #238

merged 1 commit into from
Apr 10, 2023

Conversation

Brunope
Copy link
Collaborator

@Brunope Brunope commented Apr 10, 2023

No description provided.

@Brunope Brunope force-pushed the RM-74-mypy-typecheck branch from d39d914 to 155148d Compare April 10, 2023 17:22
@Brunope
Copy link
Collaborator Author

Brunope commented Apr 10, 2023

Mypy updated and can no longer "infer" the type args to shutil.copyfileobj, even though we've already type annotated them. I tried adding extra annotations with no luck, so I'm opting to just type-ignore it.

@Brunope Brunope requested a review from ryantimjohn April 10, 2023 17:30
ryantimjohn
ryantimjohn approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@ryantimjohn ryantimjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Brunope Brunope added this pull request to the merge queue Apr 10, 2023
Merged via the queue into main with commit e774b5e Apr 10, 2023
@ryantimjohn ryantimjohn deleted the RM-74-mypy-typecheck branch April 18, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantimjohn ryantimjohn ryantimjohn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brunope @ryantimjohn