RM-45-records_mover-db-redshift-records_copy.py-13-1-C901-redshift_copy_options-is-too-complex-27 #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantimjohn
force-pushed
the
RM-45-records_mover-db-redshift-records_copy.py-13-1-C901-redshift_copy_options-is-too-complex-27
branch
from
3881656 to
31f4e7e
Compare
This reverts commit e9229d1. RM-45 Simplify redshift_copy RM-45 first draft RM-45 refactor into separate functions RM-45 lower flake8 violations RM-45 assign redshift_options compression RM-45 correct quotechar call RM-45 fix temporal call RM-45 fix dict invocation RM-45 fix mypy errors RM-45 fix unit tests RM-45 try fix unit tests RM-45 try unit test fix Revert "RM-45 try unit test fix" This reverts commit 31f4e7e. Revert "RM-45 try fix unit tests" This reverts commit ab9a21d.
ryantimjohn
force-pushed
the
RM-45-records_mover-db-redshift-records_copy.py-13-1-C901-redshift_copy_options-is-too-complex-27
branch
from
1588a0e to
2fbfcae
Compare
….py-13-1-C901-redshift_copy_options-is-too-complex-27
Brunope
reviewed
Apr 12, 2023
RM-45 type ignore RM-45 fix typecheck RM-45 put avro on top RM-45 use redshift_copy_parameters RM-45 noqa on compression hints RM-45 reinstate write_dfs call RM-45 set default value for move_count
ryantimjohn
force-pushed
the
RM-45-records_mover-db-redshift-records_copy.py-13-1-C901-redshift_copy_options-is-too-complex-27
branch
from
25287c5 to
69b0812
Compare
|
@Brunope, thanks for your help! Ready for review. |
Brunope
reviewed
Apr 13, 2023
Brunope
reviewed
Apr 13, 2023
Brunope
reviewed
Apr 13, 2023
|
converted back to draft for the Factory pattern refactor |
Brunope
approved these changes
Apr 17, 2023
|
@Brunope just added docstrings after the approval so assuming it's okay to merge 😉 |
ryantimjohn
deleted the
RM-45-records_mover-db-redshift-records_copy.py-13-1-C901-redshift_copy_options-is-too-complex-27
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.