RM-48 factor to_pandas_dtype into dictionary #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RM-48 check if is callable RM-48 call only when complicated RM-48 factor to_pandas_dtype into dictionary
ryantimjohn
force-pushed
the
RM-48-records_mover-records-schema-field-__init__.py-202-5-C901-RecordsSchemaField.to_pandas_dtype-is-too-complex-22
branch
from
0441a25 to
f4b0137
Compare
…nit__.py-202-5-C901-RecordsSchemaField.to_pandas_dtype-is-too-complex-22
Brunope
reviewed
Mar 28, 2023
| } | ||
|
|
||
| pd_dtype = field_type_to_pd_dtype_map.get(self.field_type) | ||
| if not pd_dtype: |
Brunope
reviewed
Mar 28, 2023
| raise NotImplementedError("Teach me how to handle records schema " | ||
| f"type {self.field_type}") | ||
| if self.field_type in ('integer', 'decimal') and callable(pd_dtype): |
There was a problem hiding this comment.
kind of weird to make the map but then have to special case certain types again anyway.
There was a problem hiding this comment.
Yeah... the other option was to have everything be a lambda again which was kind of a drag. Open to talking through ideas here on Monday!
Brunope
approved these changes
Mar 28, 2023
|
yeah its broken on main |
…to RM-48-records_mover-records-schema-field-__init__.py-202-5-C901-RecordsSchemaField.to_pandas_dtype-is-too-complex-22
ryantimjohn
deleted the
RM-48-records_mover-records-schema-field-__init__.py-202-5-C901-RecordsSchemaField.to_pandas_dtype-is-too-complex-22
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.