RM-46 simplify redshift records_unload #227
Conversation
| quiet_remove(unhandled_hints, 'quoting') | ||
| quiet_remove(unhandled_hints, 'doublequote') | ||
| quiet_remove(unhandled_hints, 'quotechar') | ||
| return redshift_options |
There was a problem hiding this comment.
Aren't you modifying the dict in-place already? no need to return it
There was a problem hiding this comment.
Definitely, I always have a tough time remembering in Python that when you're not passing around base data types you're passing pointers to the objects rather than copies of the objects.
There was a problem hiding this comment.
Probably because pointers is the wrong way to think about it but... mental models die hard. I was a C guy =(
There was a problem hiding this comment.
Well python is written in C so it's definitely all pointers under the hood
There was a problem hiding this comment.
It's just that like... it makes more sense when I think of python as names and objects rather than pointers and dereferencing pointers. 🤷
…C901-redshift_unload_options-is-too-complex-17' of https://github.com/bluelabsio/records-mover into RM-46-records_mover-db-redshift-records_unload.py-15-1-C901-redshift_unload_options-is-too-complex-17
…load.py-15-1-C901-redshift_unload_options-is-too-complex-17
ryantimjohn
deleted the
RM-46-records_mover-db-redshift-records_unload.py-15-1-C901-redshift_unload_options-is-too-complex-17
branch
No description provided.