Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm 65 add sphinx argparse #226

Merged
merged 5 commits into from
Mar 16, 2023
Merged

Rm 65 add sphinx argparse #226

merged 5 commits into from
Mar 16, 2023

Conversation

Brunope
Copy link
Collaborator

@Brunope Brunope commented Mar 14, 2023

No description provided.

@Brunope
Copy link
Collaborator Author

Brunope commented Mar 14, 2023

389: tests/integration/*****
381: records_mover/db/postgres/copy_options/date_input_style.py
365: setup.py


Reduce total number of bigfiles violations to 1132 or below!

Tasks: TOP => quality
(See full trace by running task with --trace)
Existing violations: 1132
Found 1135 bigfiles violations

Why did these changes trigger these failures?? And why do I need to use docker to run the bigfiles check...

@Brunope Brunope requested a review from ryantimjohn March 16, 2023 18:27
@Brunope Brunope marked this pull request as ready for review March 16, 2023 18:27
@ryantimjohn
Copy link
Contributor

389: tests/integration/*****
381: records_mover/db/postgres/copy_options/date_input_style.py
365: setup.py


Reduce total number of bigfiles violations to 1132 or below!

Tasks: TOP => quality
(See full trace by running task with --trace)
Existing violations: 1132
Found 1135 bigfiles violations

Why did these changes trigger these failures?? And why do I need to use docker to run the bigfiles check...

So, all of our quality checks are based on a repo put together called quality, which is completely separate from all of our other testing:
https://github.com/apiology/quality

I can buy the idea that we might be better off having the code for our quality checks actually built into the repo. Let's talk at our weekly meeting!

Copy link
Contributor

@ryantimjohn ryantimjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me! Let me talk through these changes with you at our weekly meeting just to confirm my understanding about what's changing in the way we handle sphinx requirements but don't have to wait till that to merge.

@Brunope Brunope added this pull request to the merge queue Mar 16, 2023
Merged via the queue into master with commit c2e15c8 Mar 16, 2023
@Brunope Brunope deleted the RM-65-add-sphinx-argparse branch March 16, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants