Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore flake8 complexity warning for pandas/read_csv_options #210

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Ignore flake8 complexity warning for pandas/read_csv_options #210

merged 2 commits into from
Feb 17, 2023

Conversation

Brunope
Copy link
Collaborator

@Brunope Brunope commented Feb 13, 2023

No description provided.

@Brunope
Ignore flake8 complexity warning for pandas/read_csv_options
0aabf74 
Decrement flake8 water mark

Bump mypy coverage
@Brunope Brunope force-pushed the RM-47-read-csv-options-too-complex branch from 312de72 to 0aabf74 Compare February 13, 2023 19:00
@Brunope
Copy link
Collaborator Author

Brunope commented Feb 13, 2023

After looking at this function, I think it's best to leave as is.

  1. It's already close to being below the threshold for complexity
  2. It has a ton of comments explaining why it is and works the way it does
  3. It really does seem to be the logical place to store the reading of these options. In my opinion it would be more confusing if this functionality was spread out into different places.

@Brunope Brunope marked this pull request as ready for review February 13, 2023 19:19
@ryantimjohn
Copy link
Contributor

This all sounds right @Brunope!

@Brunope Brunope merged commit 082e4f7 into master Feb 17, 2023
@Brunope Brunope deleted the RM-47-read-csv-options-too-complex branch February 17, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantimjohn ryantimjohn ryantimjohn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brunope @ryantimjohn