RM-34-upgrade-syntax-to-support-airflow-2-0 #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/github.com/bluelabsio/records-mover into RM-34-upgrade-syntax-to-support-airflow-2-0
ryantimjohn
commented
Jan 12, 2023
types/stubs/logging/config.pyi
Outdated
| @@ -28,7 +28,7 @@ class ConvertingDict(dict, ConvertingMixin): | |||
|
|
|||
| class ConvertingList(list, ConvertingMixin): | |||
| def __getitem__(self, key: Any): ... | |||
| def pop(self, idx: int = ...): ... | |||
| def pop(self, idx: int = ...): ... # type: ignore[override] | |||
There was a problem hiding this comment.
types/stubs/logging/config.pyi:31: error: Argument 1 of "pop" is incompatible with supertype "list"; supertype defines the argument type as "SupportsIndex" [override]
types/stubs/logging/config.pyi:31: note: This violates the Liskov substitution principle
types/stubs/logging/config.pyi:31: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
I'm not actually sure we should ignore the override error here:
https://clifford.readthedocs.io/en/v1.3.0/_modules/typing.html
https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
It seems to me that there's no reason we should be overriding pop here?
There was a problem hiding this comment.
Maybe my search wasn't accurate but I can't find anywhere ConvertingList is even referenced?
There was a problem hiding this comment.
Yeah, I've come across things in stubs that are that way. Maybe it's a place Vince used to define interface without actually implementing it?
Brunope
reviewed
Jan 17, 2023
Brunope
reviewed
Jan 17, 2023
Brunope
reviewed
Jan 17, 2023
Brunope
reviewed
Jan 17, 2023
Merged
|
Ok, @Brunope, logging out for the day but looks like tests should pass at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.