Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM-33-migrate-from-nose-to-pytest #191

Merged
merged 21 commits into from
Jan 6, 2023

Conversation

ryantimjohn
Copy link
Contributor

Migrate from nose to pytest

Additionally upgrade from deprecated convenience images as outlined here:
https://bluelabsio.atlassian.net/jira/software/projects/RM/boards/3?selectedIssue=RM-6

@ryantimjohn ryantimjohn marked this pull request as ready for review January 5, 2023 15:21
@ryantimjohn ryantimjohn requested a review from Brunope January 5, 2023 15:21
requirements.txt Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Brunope Brunope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the pandas thing, I'd prefer if we didn't change anything related to pandas versioning in this pull request in order to minimize possible breakage.

@Brunope
Copy link
Collaborator

Brunope commented Jan 6, 2023

On second thought, I'm okay with removing the versioning constraint on pandas. But I do still think it belongs in requirements.txt, because it definitely is a development requirement.

@ryantimjohn
Copy link
Contributor Author

Agree with having pandas version explicit in the reqs; I started this off of a branch where I was working on python 3.11 compatibility and those changes aren't relevant to the goal of moving to pytest!

As for explicit pandas versioning, I think I know why things are that way. Around 1.2, pandas mistakenly added an infinite recursion problem that very rarely came up, except in records mover. =) So we had a bunch of people in the #help channel asking about it. Pandas 1.1.5 and 1.4 got rid of the error, so I think now we can just allow people to build off the most modern version. /But/, will leave that change for trying to upgrade to allowing Python 3.11.

@ryantimjohn
Copy link
Contributor Author

@Brunope made requested changes, let me know if anything else needed!

@ryantimjohn ryantimjohn merged commit 6b33a76 into master Jan 6, 2023
@ryantimjohn ryantimjohn deleted the RM-33-migrate-from-nose-to-pytest branch January 6, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants