-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 3.11 test #190
Merged
ryantimjohn
merged 14 commits into
master
from
RM-22-Add-CircleCI-tests-for-Python-3.11-build
Jan 6, 2023
Merged
add 3.11 test #190
ryantimjohn
merged 14 commits into
master
from
RM-22-Add-CircleCI-tests-for-Python-3.11-build
Jan 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -120,16 +120,17 @@ def initialize_options(self) -> None: | |||
'grpcio<2.0dev,>=1.29.0', | |||
] | |||
|
|||
nose_dependencies = [ | |||
'nose' | |||
pytest_dependencies = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file, one of the 3 largest in the project, increased in size to 368 lines. The total size of those files is now 3410 lines (target: 1137). Is this file complex enough to refactor?
This reverts commit 862fb03.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.