Update all Python 3.6 tests to 3.9 #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
transitioned from calling np.asscalar to calling the cell's .item method
Brunope
reviewed
Dec 16, 2022
| @@ -568,7 +568,7 @@ workflows: | |||
| - integration_test: | |||
| name: redshift-s3-itest-old-pandas | |||
| extras: '[redshift-binary,itest]' | |||
| python_version: "3.9" | |||
| python_version: "3.8" | |||
There was a problem hiding this comment.
why is this being changed to 3.8?
There was a problem hiding this comment.
Ah I'm guessing it's because this test specifically is targeting compatibility with an old version of pandas that maybe requires an older python version? the rest of these have been bumped to 3.9 as expected.
There was a problem hiding this comment.
Tried to find a way to get around this by allowing it to build the old version of pandas in 3.9 but kept creating compounding errors
Brunope
approved these changes
Dec 16, 2022
mitchellj
approved these changes
Dec 16, 2022
…ration-tests-to-3-9-remove-build-tests-for-deprecated-python-version
ryantimjohn
deleted the
RM-7-update-default-python-image-for-integration-tests-to-3-9-remove-build-tests-for-deprecated-python-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.