Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict sqlalchemy to version 1.3.x #165

Merged
merged 1 commit into from
Apr 2, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,14 +140,14 @@ def initialize_options(self) -> None:
]

db_dependencies = [
# Without this, pip 2.20.4 with "--use-feature=2020-resolver" will
# try to install every version of SQLAlchemy while trying to solve a
# dependency conflict.
# Lower bound (>=1.3.18) is to improve package resolution performance
#
# Also, pipgrip (used to make Python formulas in Homebrew) takes
# somewhere between much longer and forever to provide its output
# without this line.
'sqlalchemy>=1.3.18',
# Upper bound (<1.4) is to avoid 1.4 which has breaking changes and is
# incompatible with python-bigquery-sqlalchemy per
# https://github.com/googleapis/python-bigquery-sqlalchemy/issues/83
# Can lift this once records-mover itself is compatible and
# other packages have appropriate restrictions in place.
'sqlalchemy>=1.3.18,<1.4',
]

smart_open_dependencies = [
Expand Down