Drop overly-complected Christmas tree tests #145
Conversation
| self.assertListEqual(mock_warning.mock_calls, | ||
| [call("Ignoring hint compression = 'LZO'"), | ||
| call("Ignoring hint quoting = 'nonnumeric'")]) | ||
| self.assertEqual(unhandled_hints, set()) |
There was a problem hiding this comment.
These tests try to validate things by a growing collection of eclectic hints which try to test a number of different things simultaneously.
Cool, I guess, but the downside is that debugging them when they fail is really hard and creates cognitive load.
Instead I'd like to test hints more individually - the tests in #144 and #140 are better examples of how I'd like to write these tests going forward.
I've been wanting to kill these for a while, but the forcing function was that I tried to debug these after making clearly safe changes and it gave me too much of a head-ache trying to detangle what was going on.
| @@ -1 +1 @@ | |||
| 93.6700 | |||
| 93.1600 | |||
There was a problem hiding this comment.
This is the downside. I'll make up for some of that in #140, for sure, but won't have time to get us back to this number.
There was a problem hiding this comment.
I do think that the complexity-reduction here is an overall benefit.
To increase test coverage around part of the code which turn hints into config for various tools, I had used a test pattern I now regret. This PR removes tests which use that pattern.