OBE: Add additional valid date formats to spec #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Ensure database connection is closed | ||
| dfs.close() # type: ignore | ||
| else: | ||
| # TODO: Can I implement a ClosableIterator type or |
There was a problem hiding this comment.
Uncompleted punchlist item detected--consider resolving or moving this to your issue tracker
.circleci/config.yml
Outdated
| @@ -551,8 +551,8 @@ workflows: | |||
| extras: '[redshift-binary,itest]' | |||
| python_version: "3.6" | |||
| db_name: demo-itest | |||
| requires: | |||
| - test-3.9 | |||
| # requires: # TODO: drop this | |||
There was a problem hiding this comment.
Uncompleted punchlist item detected--consider resolving or moving this to your issue tracker
| variant: DelimitedVariant, | ||
| hints: PartialRecordsHints = {}, | ||
| broken: bool = False, | ||
| sourcefn: Optional[Callable[[], None]] = None) -> None: # TODO fix this type |
There was a problem hiding this comment.
E261 at least two spaces before inline comment
| variant: DelimitedVariant, | ||
| hints: PartialRecordsHints = {}, | ||
| broken: bool = False, | ||
| sourcefn: Optional[Callable[[], None]] = None) -> None: # TODO fix this type |
There was a problem hiding this comment.
Uncompleted punchlist item detected--consider resolving or moving this to your issue tracker
vinceatbluelabs
changed the title
|
This is mostly OBE by the new approach suggested in #144 - but should be mined for any remaining useful code before being closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.