Fix README.md code sample errors #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinceatbluelabs
commented
Oct 2, 2020
| target = targets.table(schema_name='myschema', | ||
| table_name='mytable', | ||
| db_engine=db_engine) | ||
| results = move(source, target) |
There was a problem hiding this comment.
This looks like just a copy and past-o where the same code got put in twice!
vinceatbluelabs
commented
Oct 2, 2020
| @@ -88,7 +88,7 @@ import os | |||
| sqlalchemy_url = f"postgresql+psycopg2://username:{os.environ['DB_PASSWORD']}@hostname/database_name" | |||
| db_engine = sqlalchemy.create_engine(sqlalchemy_url) | |||
|
|
|||
| df = DataFrame.from_dict([{'a': 1}]) # or make your own! | |||
| df = DataFrame.from_dict([{'a': 1}]) # or make your own! | |||
There was a problem hiding this comment.
While we're at it, let's make our sample code pass flake8.
vinceatbluelabs
commented
Oct 2, 2020
|
|
||
| session = Session() | ||
| session.set_stream_logging() |
There was a problem hiding this comment.
As-is, this sample code didn't log. Let's give people a good starting point that they can debug from!
cwegrzyn
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.