Skip to content

Commit

Permalink
Merge pull request #205 from bluelabsio/RM-9-Enable-test-3.7-job-in-C…
Browse files Browse the repository at this point in the history
…ircleCI-config-fix-typecheck-problems

Rm 9 enable test 3.7 job in circle ci config fix typecheck problems
  • Loading branch information
ryantimjohn authored Feb 3, 2023
2 parents 5025f8c + c43e5bb commit 6980716
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 16 deletions.
21 changes: 8 additions & 13 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -397,19 +397,14 @@ workflows:
# We try to test against all non-end-of-life Python versions:
#
# https://devguide.python.org/devcycle/#end-of-life-branches
#
#
# https://app.asana.com/0/1128138765527694/1161072974798065
# - test:
# name: test-3.7
# extras: '[unittest,typecheck]'
# python_version: "3.7"
# pandas_version: "==1.1.5"
# requires:
# - redshift-s3-itest
# filters:
# tags:
# only: /v\d+\.\d+\.\d+(-[\w]+)?/
- test:
name: test-3.7
extras: '[unittest,typecheck]'
python_version: "3.7"
pandas_version: "==1.1.5"
filters:
tags:
only: /v\d+\.\d+\.\d+(-[\w]+)?/
- test:
name: test-3.8
extras: '[unittest,typecheck]'
Expand Down
2 changes: 1 addition & 1 deletion metrics/flake8_high_water_mark
Original file line number Diff line number Diff line change
@@ -1 +1 @@
9
10
3 changes: 1 addition & 2 deletions records_mover/records/mover.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,7 @@ def move(records_source: RecordsSource,
elif isinstance(records_source, SupportsToFileobjsSource):
# Incompatible types in assignment (expression has type "Optional[Any]",
# variable has type "BaseRecordsFormat")
target_records_format: BaseRecordsFormat = getattr(records_target,
"records_format", None) # type: ignore
target_records_format: BaseRecordsFormat = getattr(records_target, "records_format", None) # type: ignore
logger.info(f"Mover: copying from {records_source} to {records_target} "
f"by first writing {records_source} to {target_records_format} "
"records format (if easy to rewrite)...")
Expand Down

0 comments on commit 6980716

Please sign in to comment.